Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(trunk): update formatter configs #128

Open
t-bre opened this issue Oct 22, 2022 · 0 comments
Open

chore(trunk): update formatter configs #128

t-bre opened this issue Oct 22, 2022 · 0 comments
Labels
chore Miscellaneous chores

Comments

@t-bre
Copy link
Member

t-bre commented Oct 22, 2022

Description

clang-format is producing some questionable formatting which affects readability, especially for things on the more complex side. Things that need checked over:

  • Lambdas are hard to distinguish from other blocks - it would be better if they were more obvious. Possible solution is to not put a line break before the opening brace of the body.
  • Constructor initialiser lists are way too dense, especially when there are multiple members being initialised. Need to mess with indentations and line break settings.
  • Rules for variable names need to be standardised and checked more carefully. The case of variables is not always consistent (e.g. constexpr T memberName vs constexpr T MemberName is used in different places).

Feel free to add to this thread with things that you think are questionable about the formatting and readability! Making changes to the auto formatter can cause a bunch of merge conflicts, so its better to make a bunch of changes at once and find a quiet time to do it.

@t-bre t-bre added the chore Miscellaneous chores label Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Miscellaneous chores
Projects
None yet
Development

No branches or pull requests

1 participant