Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate timemap when publishing web archives #4337

Open
jcoyne opened this issue Feb 2, 2023 · 0 comments
Open

Calculate timemap when publishing web archives #4337

jcoyne opened this issue Feb 2, 2023 · 0 comments
Labels

Comments

@jcoyne
Copy link
Contributor

jcoyne commented Feb 2, 2023

Currently the viewer is dynamically looking up the timemap url based on the "Archived website" url in the MODS.

https://github.com/sul-dlss/sul-embed/blob/921130b790b8b7babd41c2e004535e3b12028303/app/viewers/embed/viewer/was_seed.rb#L32-L40

This process could error (because networks are not 100% reliable), and present an error to the user. Instead we should do this process at publish time, where it can retry (since publish is a robot) if there is a failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants