Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renovate の PR の内容が linter に怒られることを防ぎたい #93

Closed
sunakan opened this issue Dec 26, 2022 · 3 comments · Fixed by #94
Closed

Renovate の PR の内容が linter に怒られることを防ぎたい #93

sunakan opened this issue Dec 26, 2022 · 3 comments · Fixed by #94
Assignees

Comments

@sunakan
Copy link
Contributor

sunakan commented Dec 26, 2022

概要

#87 (comment)

等で PR 内容が

21:1    error  Line 21 sentence length(119) exceeds the maximum sentence length of 100.
Over 19 characters  ja-technical-writing/sentence-length
28:1    error  Line 28 sentence length(111) exceeds the maximum sentence length of 100.
Over 11 characters  ja-technical-writing/sentence-length
55:248  error  This sentence exceeds the maximum count of comma. Maximum is 3            ja-technical-writing/max-comma
63:1    error  Line 63 sentence length(112) exceeds the maximum sentence length of 100.
Over 12 characters  ja-technical-writing/sentence-length

と怒られる

なんとかしたい

@sunakan sunakan self-assigned this Dec 26, 2022
@sunakan
Copy link
Contributor Author

sunakan commented Dec 26, 2022

renovateはブランチ名に命名規則があるので、それで pr に対して lint をかけないでも良さそう

GitHub Actions のワークフロー構文 > 例: ブランチの除外

例だと以下の感じ

on:
  pull_request:
    # Sequence of patterns matched against refs/heads
    branches-ignore:    
      - 'mona/octocat'
      - 'releases/**-alpha'

@sunakan
Copy link
Contributor Author

sunakan commented Dec 26, 2022

on:
  pull_request:
    branches-ignore:
      - 'renovate/*'

でいけそう

@sunakan
Copy link
Contributor Author

sunakan commented Dec 26, 2022

GitHubの検索キーワード「extension:yml branches-ignore renovate」

https://github.com/search?q=extension%3Ayml+branches-ignore+renovate

を見ると '*' は2個が一般的なのかもしれない

on:
  pull_request:
    branches-ignore:
      - 'renovate/**'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant