Some ideas ...

[jantielens]

Hi @suneetnangia , I was playing around with IoT Edge and thought: "Hey it would be useful to have an IoT Edge Module to easily use IoT Hub Device Streams". It seems you had exactly the same idea. (great minds ... 😄 )

I've got your module up and running, and I have some ideas/suggestions.

1. It seems when you don't provide the 3 environment variables for all the 3 protocols (SSH, SCP, RDP) to the module, the module doesn't start. In my scenario I only needed SSH, so I had to create 2 extra IoT Devices to get the module running. Suggestion: check which environment variables are present, and only start the stream for those.
2. When the module doesn't have the the necessary environment variables, it starts and it starts dumping error messages in the output (a lot, very fast). Suggestion: when the module can't start, log the problem and shutdown the module. So you'll notice the problem in de edgeAgent logs, the Azure Portal, ...

To make suggestion 1 more convincing: I'd argue that if you have SSH, you can tunnel any protocol you'd like. (so no need for any other protocols) E.g. using the ssh -L option.

Before creating a PR I'd love to hear your ideas around this. If you don't feel my suggestions suits your needs/requirements/... : no worries. I'll respectfully fork and made the modifications on my side. 😄

Anyway, thanks for your work!
J