エンジン設定比較でエンジンを変更するたびにフィルターがリセットされる問題を修正

[sunfish-shogi]

説明 / Description

#1214

チェックリスト / Checklist

• MUST
  • npm test passed
  • npm run lint was applied without warnings
  • changes of /docs/webapp not included (except release branch)
  • console.log not included (except script file)
• MUST for Outside Contributor
  • understand プロジェクトへの関わり方について
• RECOMMENDED (it depends on what you change)
  • unit test added/updated
  • i18n

Summary by CodeRabbit

• Refactor
  • Simplified tag selection logic for a smoother user experience when choosing tags.
  • Improved default tag handling, making initial tag selection more reliable and consistent.
  • Updated naming in tag selection components for better clarity.

[coderabbitai]

Walkthrough

The changes refactor how selected tags are managed and passed between the PlayerSelector.vue and DropdownList.vue components. The DropdownList component now uses a Set for selected tags instead of a Map, and the prop for initial selection is renamed from selectedTags to defaultTags. The logic for handling and toggling tag selection is simplified accordingly.

Changes

File(s)	Change Summary
src/renderer/view/dialog/PlayerSelector.vue	Introduced a computed defaultTags array, updated prop passing to DropdownList, and simplified defaultTag prop definition.
src/renderer/view/primitive/DropdownList.vue	Changed internal tag selection state from Map to Set, renamed prop selectedTags to defaultTags, and simplified selection logic.

Sequence Diagram(s)

sequenceDiagram
    participant PlayerSelector
    participant DropdownList

    PlayerSelector->>DropdownList: Passes :default-tags="defaultTags"
    DropdownList->>DropdownList: Initializes Set of selected tags from defaultTags
    User->>DropdownList: Clicks on a tag
    DropdownList->>DropdownList: Toggles tag in Set
    DropdownList->>PlayerSelector: Emits updated selection (if applicable)

Loading

Possibly related PRs

• Fix dropdown list filter #1198: Both PRs modify the initialization and synchronization of selected tags in DropdownList.vue, focusing on how tag states are managed and updated.

Suggested labels

bug

Poem

A hop and a skip, a change in the air,
From Map to Set, with logic laid bare.
Tags now selected, with simpler delight,
Dropdowns and selectors, working just right.
🐇✨

The code now is nimble, the bugs out of sight!

Tip

⚡️ Faster reviews with caching

• CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 74534f5 and 37dd712.

📒 Files selected for processing (2)

• src/renderer/view/dialog/PlayerSelector.vue (2 hunks)
• src/renderer/view/primitive/DropdownList.vue (5 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Analyze (javascript)

🔇 Additional comments (8)

src/renderer/view/primitive/DropdownList.vue (6)

14-16: Clean simplification of tag selection logic

This change simplifies the tag toggling logic by using Set methods (add/delete) instead of Map operations, making the code more readable and maintainable.

---

61-64: Good rename from selectedTags to defaultTags

The prop name defaultTags better reflects its purpose as the initial state rather than the current selection state, which is now maintained internally.

---

72-72: Improved data structure choice

Changing from a Map to a Set is more appropriate for this use case since we only need to track membership (selected or not) without associating values with each tag.

---

76-76: Simplified selection check

Using tagStates.has(tag.name) is cleaner and more direct than retrieving a boolean from a Map.

---

90-90: Cleaner filtering logic

The filtering logic is now more straightforward using Set membership rather than Map value checking.

---

119-124: Updated watcher for prop name change

The watcher now correctly handles the renamed prop, clearing and populating the Set with the new default tags.

src/renderer/view/dialog/PlayerSelector.vue (2)

7-7: Updated prop name to match component changes

Correctly updated the prop binding from :selected-tags to :default-tags to match the changes in the DropdownList component.

---

62-62: Added computed property for default tags

This computed property elegantly handles the case when defaultTag is null or undefined by returning an empty array, maintaining reactivity while correctly formatting the input for the DropdownList component.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.58%. Comparing base (74534f5) to head (37dd712).
Report is 4 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1218   +/-   ##
=======================================
  Coverage   78.58%   78.58%           
=======================================
  Files         129      129           
  Lines       16356    16356           
  Branches     2719     2719           
=======================================
  Hits        12853    12853           
  Misses       3481     3481           
  Partials       22       22           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sunfish-shogi]

メモ
:selected-tags に式を直接書くと計算結果が変わっていなくても DropdownList の watch が発火してしまう。
不具合の修正に必要な実装はこれだけで、他の変更はリファクタリングとして入れた。