Skip to content

Commit 980b447

Browse files
committed
refactor: session id로 검사하는 로직 제거
1 parent bc19b42 commit 980b447

File tree

2 files changed

+2
-12
lines changed

2 files changed

+2
-12
lines changed

server/src/main/java/sunflower/server/api/MemberApiController.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,7 @@ public ResponseEntity<Void> login(@RequestBody LoginRequest request, HttpServlet
3636
final Long id = memberService.login(request.getLoginId(), request.getPassword());
3737
final String sessionId = sessionService.createSessionId(id);
3838

39-
response.setHeader("Set-Cookie", "sessionId=" + sessionId + "; HttpOnly; Max-Age=3600; Path=/; Secure; SameSite=None"); // 사용중이지 않음
40-
// response.setHeader("SessionId", sessionId); // 임시 사용중
39+
response.setHeader("Set-Cookie", "sessionId=" + sessionId + "; HttpOnly; Max-Age=3600; Path=/; Secure; SameSite=None");
4140

4241
return ResponseEntity
4342
.status(HttpStatus.OK.value())

server/src/main/java/sunflower/server/application/resolver/MemberAuthArgumentResolver.java

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ public boolean supportsParameter(final MethodParameter parameter) {
3030
@Override
3131
public Object resolveArgument(final MethodParameter parameter, final ModelAndViewContainer mavContainer, final NativeWebRequest webRequest, final WebDataBinderFactory binderFactory) throws Exception {
3232
HttpServletRequest request = (HttpServletRequest) webRequest.getNativeRequest();
33-
String encryptedSessionId = findEncryptedSessionId(request);
33+
String encryptedSessionId = extractSessionId(request.getCookies());
3434

3535
if (encryptedSessionId == null) {
3636
throw new AuthException();
@@ -46,15 +46,6 @@ public Object resolveArgument(final MethodParameter parameter, final ModelAndVie
4646
}
4747
}
4848

49-
private String findEncryptedSessionId(final HttpServletRequest request) {
50-
// final String sessionId = request.getHeader("SessionId");
51-
// if (sessionId != null) {
52-
// return sessionId;
53-
// }
54-
55-
return extractSessionId(request.getCookies());
56-
}
57-
5849
private String extractSessionId(final Cookie[] cookies) {
5950
if (cookies == null) {
6051
throw new AuthException();

0 commit comments

Comments
 (0)