-
Notifications
You must be signed in to change notification settings - Fork 575
fix(web3): normalize Ethereum addresses to lowercase to prevent case-… #2265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lingcoder
wants to merge
3
commits into
supabase:master
Choose a base branch
from
lingcoder:feature/fix-siwe
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 17 additions & 0 deletions
17
migrations/20251202014000_normalize_web3_ethereum_addresses.up.sql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| -- Normalize Ethereum addresses in provider_id to lowercase to prevent case-sensitivity issues | ||
| -- This migration must run BEFORE deploying the code change that lowercases addresses in parser.go | ||
| -- Background: Ethereum addresses are case-insensitive, but EIP-55 uses mixed case for checksums. | ||
| -- This migration ensures existing checksummed addresses are normalized to lowercase to match | ||
| -- the new behavior where addresses are lowercased at parse time. | ||
| -- | ||
| -- Note: identity_data is NOT updated because it's only metadata for display purposes. | ||
| -- The provider_id field is the only field used for identity lookup and uniqueness. | ||
|
|
||
| /* auth_migration: 20251202014000 */ | ||
|
|
||
| -- Update all web3:ethereum provider_id entries to use lowercase addresses | ||
| -- Format: "web3:ethereum:0xABCDEF..." -> "web3:ethereum:0xabcdef..." | ||
| update {{ index .Options "Namespace" }}.identities | ||
| set provider_id = lower(provider_id) | ||
| where provider = 'web3' | ||
| and provider_id LIKE 'web3:ethereum:0x%'; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.