Skip to content

😭 fixing builds#767

Merged
Dhravya merged 1 commit intomainfrom
03-05-_fixing_builds
Mar 6, 2026
Merged

😭 fixing builds#767
Dhravya merged 1 commit intomainfrom
03-05-_fixing_builds

Conversation

@Dhravya
Copy link
Member

@Dhravya Dhravya commented Mar 6, 2026

No description provided.

@Dhravya Dhravya marked this pull request as ready for review March 6, 2026 02:16
Copy link
Member Author

Dhravya commented Mar 6, 2026


How to use the Graphite Merge Queue

Add the label Main to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Mar 6, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
supermemory-app 1c24848 Commit Preview URL Mar 06 2026, 03:25 AM

@Dhravya Dhravya force-pushed the 03-05-_fixing_builds branch 4 times, most recently from d86554b to 9e46ce1 Compare March 6, 2026 02:22
"@tanstack/react-query-devtools": "^5.84.2",
"ai-gateway-provider": "^0.0.11",
"better-auth": "^1.3.3",
"better-auth": "^1.5.3",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Upgrading better-auth to v1.5 moves apiKeyClient to a separate package. The code still uses the old import path, which will cause runtime failures.
Severity: CRITICAL

Suggested Fix

Add the new @better-auth/api-key package to the dependencies in the relevant package.json file. Then, update all imports of apiKeyClient from "better-auth/client/plugins" to "@better-auth/api-key/client" to reflect the new package structure.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: packages/lib/package.json#L17

Potential issue: The upgrade of `better-auth` to version `1.5.3` introduces a breaking
change. The `apiKeyClient`, previously available in `"better-auth/client/plugins"`, has
been moved to a new, separate package: `@better-auth/api-key`. However, the import
statements in files like `packages/lib/auth.ts` have not been updated to reflect this
change, and the new package has not been added as a dependency. This will cause
`apiKeyClient` to be `undefined` at runtime, leading to application-wide failures
wherever API key functions like `create()`, `list()`, or `delete()` are used.

Did we get this right? 👍 / 👎 to inform future reviews.

@Dhravya Dhravya force-pushed the 03-05-_fixing_builds branch 12 times, most recently from 289513a to 66f8a39 Compare March 6, 2026 03:20
@Dhravya Dhravya force-pushed the 03-05-_fixing_builds branch from 66f8a39 to 1c24848 Compare March 6, 2026 03:23
@Dhravya Dhravya merged commit 1afb901 into main Mar 6, 2026
6 checks passed
Copy link
Member

lol🤣 , imports was the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants