feat: bulk delete documents in nova app by MaheshtheDev · Pull Request #777 · supermemoryai/supermemory

MaheshtheDev · 2026-03-10T05:36:30Z

cloudflare-workers-and-pages · 2026-03-10T05:36:43Z

Deploying with Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Updated (UTC)
❌ Deployment failed View logs	supermemory-app	`022fab2`	Mar 10 2026, 05:36 AM

MaheshtheDev · 2026-03-10T05:36:44Z

feat: bulk delete documents in nova app #777 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add the label Main to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

cloudflare-workers-and-pages · 2026-03-10T05:36:45Z

Deploying with Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Preview URL	Updated (UTC)
✅ Deployment successful! View logs	supermemory-app	`71c7400`	Commit Preview URL	Mar 10 2026, 07:52 AM

sentry · 2026-03-10T05:39:06Z

apps/web/app/(app)/page.tsx

+			{ documentIds: ids },
+			{
+				onSuccess: () => {
+					setSelectedDocumentIds(new Set())
+					setIsSelectionMode(false)
+					if (selectedDocument && ids.includes(selectedDocument.id ?? "")) {
+						setDocId(null)
+					}
+				},
+			},
+		)


Bug: Performing a bulk delete clears any unsaved text in the quick note draft input due to an onSuccess callback firing unintentionally.
_{Severity: MEDIUM}

Suggested Fix

Decouple the onClose logic from the bulk delete mutation's onSuccess callback. The onSuccess for bulkDeleteMutation should only handle logic related to the deletion itself, such as clearing selection state. The resetDraft() function should not be called as a side effect of a successful bulk deletion.

Prompt for AI Agent

Review the code at the location below. A potential bug has been identified by an AI agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not valid. Location: apps/web/app/(app)/page.tsx#L186-L197 Potential issue: When a user performs a bulk delete operation, two separate `onSuccess` callbacks are triggered. One is defined at the `useMutation` level, which calls an `onClose` handler that in turn calls `resetDraft()`. This occurs even if the user has unsaved text in the quick note input field. The `resetDraft()` function then clears this unsaved text without warning, leading to data loss for the user. This bug is triggered specifically when a user has an unsaved quick note draft and successfully completes a bulk delete action.

_{Did we get this right? 👍 / 👎 to inform future reviews.}

Prasanna721

can you fix the build issues?

Prasanna721 · 2026-03-10T06:54:36Z

can select & delete button can be at the right of dismiss?

MaheshtheDev · 2026-03-10T07:25:59Z

can select & delete button can be at the right of dismiss?

what do you mean @Prasanna721 i didn't get it

claude · 2026-03-10T07:38:35Z

Claude finished @MaheshtheDev's task in 58s —— View job

Review Complete

Gather context from PR and existing review comments
Review the PR diff for bugs, security issues, and logic errors
Check if previous review issues have been addressed
Submit review findings

Overview: Adds bulk delete functionality for documents in the nova app with selection mode UI.

Previously flagged issues - now resolved:

Bug (fixed): The onClose?.() call that was unintentionally clearing the quick note draft has been removed from bulkDeleteMutation.onSuccess (use-document-mutations.ts:546-552)
Bug (fixed): The pluralization issue ("memoryies") has been corrected to properly display "memory" or "memories" (memories-grid.tsx:462)

Issues found: None - this looks good to ship.

Score: 9/10

Good implementation with selection mode UI, optimistic updates, proper error handling with rollback, and a confirmation dialog. All previously identified bugs have been addressed. The Cloudflare deployment failure mentioned in comments appears to be infrastructure-related rather than a code issue in this PR.

claude

Overview: Adds bulk delete functionality for documents in the nova app with selection mode UI.

Issues found:

Bug (confirmed from Sentry): bulkDeleteMutation.onSuccess calls onClose?.() which resets the quick note draft unintentionally. Users with unsaved text in the quick note input will lose their draft when performing bulk delete. See inline comment for the fix.

Regarding build issues: The TypeScript errors in the type-check output are pre-existing in @supermemory/tools (test files) and unrelated to this PR's changes. The Cloudflare deployment failure appears to be infrastructure-related rather than a code issue in this PR.

Score: 8/10

Good implementation overall - the selection mode UI, optimistic updates, and confirmation dialog are well done. Just needs the one bug fix before merging.

claude · 2026-03-10T07:41:50Z

apps/web/hooks/use-document-mutations.ts

+			)
+			queryClient.invalidateQueries({ queryKey: ["documents-with-memories"] })
+			onClose?.()
+		},


Bug confirmed: The Sentry AI report is correct. Calling onClose?.() here will unintentionally clear the quick note draft when bulk delete succeeds.

The onClose callback is designed for note/link/file mutations where the user saves content and the modal closes (resetting the draft makes sense there). But for bulk delete, this side effect is unexpected - users deleting documents shouldn't lose their unsaved quick note text.

Fix: Remove onClose?.() from this onSuccess callback. The inline onSuccess in handleBulkDelete already handles clearing selection state appropriately.

Suggested change

},

onSuccess: (_data, variables) => {

analytics.documentsBulkDeleted({ count: variables.documentIds.length })

toast.success(

`${variables.documentIds.length} document${variables.documentIds.length === 1 ? "" : "s"} deleted`,

)

queryClient.invalidateQueries({ queryKey: ["documents-with-memories"] })

},

apps/web/components/memories-grid.tsx

+							This will permanently delete {selectedDocumentIds.size} memory
+							{selectedDocumentIds.size === 1 ? "" : "ies"}. This action cannot
+							be undone.
+						</AlertDialogDescription>


feat: bulk delete documents in nova app

022fab2

MaheshtheDev marked this pull request as ready for review March 10, 2026 05:36

graphite-app bot requested a review from Dhravya March 10, 2026 05:36

graphite-app bot assigned MaheshtheDev Mar 10, 2026

sentry bot reviewed Mar 10, 2026

View reviewed changes

Prasanna721 reviewed Mar 10, 2026

View reviewed changes

revert bun lock file

351c10d

claude bot reviewed Mar 10, 2026

View reviewed changes

fix sentry issue

df11394

sentry bot reviewed Mar 10, 2026

View reviewed changes

fix spelling mistake

71c7400

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: bulk delete documents in nova app#777

feat: bulk delete documents in nova app#777
MaheshtheDev wants to merge 4 commits intomainfrom
03-10-feat_bulk_delete_documents_in_nova_app

MaheshtheDev commented Mar 10, 2026 •

edited

Loading

Uh oh!

cloudflare-workers-and-pages bot commented Mar 10, 2026

Uh oh!

MaheshtheDev commented Mar 10, 2026

Uh oh!

cloudflare-workers-and-pages bot commented Mar 10, 2026 •

edited

Loading

Uh oh!

sentry bot Mar 10, 2026

Uh oh!

Prasanna721 left a comment

Uh oh!

Prasanna721 commented Mar 10, 2026 •

edited

Loading

Uh oh!

MaheshtheDev commented Mar 10, 2026

Uh oh!

claude bot commented Mar 10, 2026 •

edited

Loading

Uh oh!

claude bot left a comment

Uh oh!

claude bot Mar 10, 2026

Uh oh!

This comment was marked as outdated.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

-		},
+		onSuccess: (_data, variables) => {
+			analytics.documentsBulkDeleted({ count: variables.documentIds.length })
+			toast.success(
+				`${variables.documentIds.length} document${variables.documentIds.length === 1 ? "" : "s"} deleted`,
+			)
+			queryClient.invalidateQueries({ queryKey: ["documents-with-memories"] })
+		},

Conversation

MaheshtheDev commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cloudflare-workers-and-pages bot commented Mar 10, 2026

Deploying with Cloudflare Workers

Uh oh!

MaheshtheDev commented Mar 10, 2026

How to use the Graphite Merge Queue

Uh oh!

cloudflare-workers-and-pages bot commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying with Cloudflare Workers

Uh oh!

sentry bot Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

Prasanna721 left a comment

Choose a reason for hiding this comment

Uh oh!

Prasanna721 commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MaheshtheDev commented Mar 10, 2026

Uh oh!

claude bot commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review Complete

Uh oh!

claude bot left a comment

Choose a reason for hiding this comment

Uh oh!

claude bot Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

MaheshtheDev commented Mar 10, 2026 •

edited

Loading

cloudflare-workers-and-pages bot commented Mar 10, 2026 •

edited

Loading

Prasanna721 commented Mar 10, 2026 •

edited

Loading

claude bot commented Mar 10, 2026 •

edited

Loading