Skip to content

Commit b58d5e2

Browse files
committed
Support Range :values in catalogue
1 parent 16364ae commit b58d5e2

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

lib/surface/catalogue/components/component_api.ex

+4
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,10 @@ defmodule Surface.Catalogue.Components.ComponentAPI do
122122
"—"
123123
end
124124

125+
defp format_values(%Range{} = range) do
126+
raw(["<code>", inspect(range), "</code>"])
127+
end
128+
125129
defp format_values(values) do
126130
values
127131
|> Enum.map(fn value -> raw(["<code>", format_value(value), "</code>"]) end)

lib/surface/catalogue/components/prop_input.ex

+3-6
Original file line numberDiff line numberDiff line change
@@ -126,15 +126,12 @@ defmodule Surface.Catalogue.Components.PropInput do
126126
defp css_value_to_string(nil), do: nil
127127
defp css_value_to_string(value), do: Enum.join(value, " ")
128128

129-
defp get_choices(prop) do
130-
values =
131-
prop.opts
132-
|> Keyword.get(:values, [])
133-
|> Enum.map(&{&1, &1})
129+
defp get_choices(%{opts: opts}) do
130+
values = for x <- Keyword.get(opts, :values, []), do: {x, x}
134131

135132
cond do
136133
values == [] -> []
137-
prop.opts[:required] -> values
134+
opts[:required] -> values
138135
true -> [{"nil", "__NIL__"} | values]
139136
end
140137
end

0 commit comments

Comments
 (0)