Create the service provider

Added test for command
Add ServiceProvider.stub file

Author: leganz

composer.json

@@ -1,5 +1,5 @@
 {
-    "name": "ambersive/laravel-packagemaker",
+    "name": "ambersive/packagemaker",
     "description": "This package helps you to create laravel packages.",
     "license": "MIT",
     "authors": [
@@ -21,7 +21,8 @@
     },
     "autoload": {
         "psr-4": {
-            "AMBERSIVE\\PackageMaker\\": "src/"
+            "AMBERSIVE\\PackageMaker\\": "src/",
+            "AMBERSIVE\\PackageMaker\\Tests": "test/"
         }
     },
     "extra": {

src/Console/Commands/Dev/MakePackage.php

@@ -82,6 +82,8 @@ public function handle()
         $this->generatePhpUnitFile() == false ? $this->error("[${name}] phpunit.xml file could not be created.") : $this->line("[${name}] phpunit.xml file has been created.");
         $this->generateEmptyFolder("tests") === false ? $this->error("[${name}] test folder could not be created.") : $this->line("[${name}] test folder has been created.");
         $this->generateEmptyFolder("docs") === false ? $this->error("[${name}] docs folder could not be created.") : $this->line("[${name}] docs folder has been created.");
+        $this->generateEmptyFolder("src") === false ? $this->error("[${name}] src folder could not be created.") : $this->line("[${name}] src folder has been created.");
+        $this->generateServiceProvider() === false ? $this->error("[${name}] service provider coult not be created.") : $this->line("[${name}] service provider has been created.");
 
         $this->info("The package ${name} has been created.");
 
@@ -93,7 +95,12 @@ public function handle()
         }
 
     }
-
+    
+    /**
+     * Returns list of possible laravel versions.
+     *
+     * @return array
+     */
     protected function getLaravelVersionLists(): array {
 
         $file = json_decode(File::get(__DIR__."/../../../../composer.json"), true);
@@ -189,18 +196,26 @@ protected function generateComposerFile():bool {
         $path = $this->getPath($this->packageName."/composer.json");
         $stub = $this->files->get($this->getStubFilePath("composer"));
 
+        $splittedName = explode("/", $this->packageName);
+        $name         = ucfirst(Str::camel($splittedName[sizeOf($splittedName) - 1]."ServiceProvider"));
+        $namespace    = $this->getNamespace(ucfirst($splittedName[0])."\\".ucfirst(Str::camel($splittedName[1]))."\\".$name);
+
         $content = $this->replaceTokens($stub, [
             "{PACKAGE_NAME}",
             "{PACKAGE_DESCRIPTION}",
             "{EMAIL}",
             "{NAME}",
-            "{LARAVEL_VERSION}"
+            "{LARAVEL_VERSION}",
+            "{NAMESPACE}",
+            "{PROVIDER}"
         ], [
             $this->packageName,
             $this->packageDescription,
             $this->packageCreatorEmail,
             $this->packageCreatorName,
-            implode("|", $this->packageLaravelVersions)
+            implode("|", $this->packageLaravelVersions),
+            str_replace("\\","\\\\",$namespace),
+            $name
         ]);
 
         $this->makeDirectory($path);
@@ -253,6 +268,30 @@ protected function generateEmptyFolder(String $folder): bool {
         return $success;
 
     }
+    
+    /**
+     * Generate the required service provider
+     *
+     * @return bool
+     */
+    protected function generateServiceProvider(): bool {
+
+        $splittedName = explode("/", $this->packageName);
+        $name         = ucfirst(Str::camel($splittedName[sizeOf($splittedName) - 1]."ServiceProvider"));
+
+        $path           = $this->getPath("$this->packageName/src/${name}.php");
+
+        $this->files->put($path, $this->sortImports($this->buildClassCustom($name, 'ServiceProvider', [
+            'DummyNamespace'
+        ], [
+            $this->getNamespace(ucfirst($splittedName[0])."\\".ucfirst(Str::camel($splittedName[1]))."\\".$name)
+        ])));
+
+        $success = File::exists($path);
+
+        return $success; 
+
+    }
 
     /**
      * Build the class with the given name.
@@ -262,9 +301,9 @@ protected function generateEmptyFolder(String $folder): bool {
      *
      * @throws \Illuminate\Contracts\Filesystem\FileNotFoundException
      */
-    protected function buildClassCustom(String $name, String $stubname) {
+    protected function buildClassCustom(String $name, String $stubname, array $placeholder = [], array $replaceWith = []) {
         $stub = $this->files->get($this->getStubFilePath($stubname));
-        return $this->replaceNamespace($stub, $name)->replaceClass($stub, $name);
+        return $this->replaceNamespaceCustom($stub, $placeholder, $replaceWith)->replaceClass($stub, $name);
     }
 
     /**
@@ -276,6 +315,16 @@ protected function getStubFilePath(String $stubname):String {
         return $this->getStub()."${stubname}.stub";
     }
 
+    protected function replaceNamespaceCustom(&$stub, array $placeholder = [], array $replaceWith = []) {
+        $stub = str_replace(
+            $placeholder,
+            $replaceWith,
+            $stub
+        );
+
+        return $this;
+    }
+
     protected function replaceTokens(&$stub, array $placeholder = [], array $replaceWith = []) {
         $stub = str_replace(
             $placeholder,

src/Stubs/README.stub

@@ -10,11 +10,6 @@ Changes between versions will be tracked in the [CHANGELOG](CHANGELOG.md).
 composer require {PACKAGE_NAME}
 ```
 
-## Usage
-
-
-This command will create a scaffold for your next laravel project.
-
 ## Feedback
 
 Please feel free to give us feedback or any improvement suggestions.

src/Stubs/ServiceProvider.stub

@@ -0,0 +1,36 @@
+<?php
+
+namespace DummyNamespace;
+
+use App;
+use Str;
+
+use Illuminate\Foundation\AliasLoader;
+
+use Illuminate\Support\ServiceProvider;
+
+class DummyClass extends ServiceProvider
+{
+
+    /**
+     * Register services.
+     *
+     * @return void
+     */
+    public function register()
+    {
+        
+    }
+
+    /**
+     * Bootstrap services.
+     *
+     * @return void
+     */
+    public function boot()
+    {
+       
+    }
+
+
+}

src/Stubs/composer.stub

@@ -21,14 +21,14 @@
     },
     "autoload": {
         "psr-4": {
-            "AMBERSIVE\\KeepAChangelog\\": "src/"
+            "{NAMESPACE}\\": "src/"
         }
     },
     "extra": {
         "component": "package",
         "laravel": {
             "providers": [
-                "AMBERSIVE\\KeepAChangelog\\ChangelogServiceProvider"
+                "{NAMESPACE}\\{PROVIDER}"
             ]
         }
     },

tests/Unit/MakeCommandTest.php

@@ -0,0 +1,76 @@
+<?php
+
+namespace AMBERSIVE\PackageMaker\Tests\Unit;
+
+use Tests\TestCase;
+
+use Config;
+use File;
+
+use Illuminate\Foundation\Testing\WithFaker;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+use Illuminate\Foundation\Testing\DatabaseMigrations;
+use Illuminate\Foundation\Testing\DatabaseTransactions;
+
+class MakeCommandTest extends TestCase
+{
+
+    protected function setUp(): void
+    {
+        parent::setUp();
+        Config::set("package-maker.path", "tmp");
+
+        shell_exec("rm -rf ".base_path("tmp"));
+        mkdir(base_path("tmp"));
+    }
+
+    protected function tearDown(): void
+    {
+        parent::tearDown();
+        shell_exec("rm -rf ".base_path("tmp"));
+    }
+    
+    /**
+     * Test if the missing name property will throw an exception
+     */
+    public function testIfMakePackageCommandWillHaveAnException():void {
+
+        $this->expectException(\Symfony\Component\Console\Exception\RuntimeException::class);
+        $this->artisan('make:package')->assertExitCode(1);
+
+    }
+
+    /**
+     * Test if the name "demo" will throw an error 
+     */
+    public function testIfMakePackageCommandWillNotHaveAnException():void {
+
+        $this->artisan('make:package', ['name' => 'demo'])->expectsOutput('Invalid package name. Please make sure you choose a valid package name. eg. ambersive/demo.')->assertExitCode(0);
+
+    }
+
+    /**
+     * Test if the package with its content will be created
+     */
+    public function testIfMakePackageCommandWillCreatePackageIfAllParamsAreCorrect():void {
+
+        $this->artisan('make:package', ['name' => 'ambersive/demo'])
+            ->expectsQuestion('Whats the purpose of this package?', 'Demo Package')
+            ->expectsQuestion('Whats your name?', 'Manuel')
+            ->expectsQuestion('Whats you e-mail address?', 'manuel.pirker-ihl@ambersive.com')
+            ->expectsQuestion('For which laravel versions do you want to create this plugin.', ["dev-master"])
+            ->assertExitCode(0);
+
+        $this->assertTrue(File::exists(base_path("tmp/ambersive/demo/README.md")));
+        $this->assertTrue(File::exists(base_path("tmp/ambersive/demo/CHANGELOG.md")));
+        $this->assertTrue(File::exists(base_path("tmp/ambersive/demo/composer.json")));
+        $this->assertTrue(File::exists(base_path("tmp/ambersive/demo/src/DemoServiceProvider.php")));
+
+        $content = File::get(base_path("tmp/ambersive/demo/src/DemoServiceProvider.php"));
+
+        $this->assertNotFalse(strpos($content, "class DemoServiceProvider"));
+        $this->assertNotFalse(strpos($content, "namespace Ambersive\Demo;"));
+
+    }
+
+}