Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node2nix --help is not updated with --nodejs-16 option #291

Open
quinn-dougherty opened this issue Apr 19, 2022 · 3 comments
Open

node2nix --help is not updated with --nodejs-16 option #291

quinn-dougherty opened this issue Apr 19, 2022 · 3 comments

Comments

@quinn-dougherty
Copy link

node2nix --help does not inform the user that 16 functionality is there.

@svanderburg
Copy link
Owner

Hmm really? I can clearly see, that for me it's there:

$ node2nix --help
...
  -16, --nodejs-16              Provides all settings to generate expression for usage with Node.js 16.x (default is: Node.js 12.x)

@CMCDragonkai
Copy link

Hey might be referring to the node2nix that is in nixpkgs master. On revision NixOS/nixpkgs@a5774e7 node2nix is still 1.9.0 even though it claims to be 1.10.0.

nix-repl> pkgs.nodePackages.node2nix.version
"1.10.0"

nix-repl> node2nix
«derivation /nix/store/ipkkiavdmj2m8m9zxdkjsd8kfxqdj27c-node2nix-1.10.0.drv»

nix-repl> :b node2nix
[62 copied (334.6 MiB), 79.6 MiB DL]

this derivation produced the following outputs:
  out -> /nix/store/nz0fw6vhdfhv45nzlxahp6383p3m9lyj-node2nix-1.10.0

But:

$ /nix/store/nz0fw6vhdfhv45nzlxahp6383p3m9lyj-node2nix-1.10/bin/node2nix --version
node2nix 1.9.0
$ /nix/store/nz0fw6vhdfhv45nzlxahp6383p3m9lyj-node2nix-1.10/bin/node2nix --help | grep nodejs
  -4, --nodejs-4                Provides all settings to generate expression for usage with Node.js 4.x (default is: Node.js 12.x)
  -6, --nodejs-6                Provides all settings to generate expression for usage with Node.js 6.x (default is: Node.js 12.x)
  -8, --nodejs-8                Provides all settings to generate expression for usage with Node.js 8.x (default is: Node.js 12.x)
  -10, --nodejs-10              Provides all settings to generate expression for usage with Node.js 10.x (default is: Node.js 12.x)
  -12, --nodejs-12              Provides all settings to generate expression for usage with Node.js 12.x (default is: Node.js 12.x)
  -13, --nodejs-13              Provides all settings to generate expression for usage with Node.js 13.x (default is: Node.js 12.x)
  -14, --nodejs-14              Provides all settings to generate expression for usage with Node.js 14.x (default is: Node.js 12.x)
  --pkg-name NAME               Specifies the name of the Node.js package to use from Nixpkgs (defaults to: nodejs)

It doesn't even show the --nodejs-16 option.

@andersk
Copy link
Contributor

andersk commented Jun 18, 2022

nixpkgs.node2nix was upgraded in NixOS/nixpkgs#171195. I think this issue can be closed. Node 16 still doesn’t work, but we have other issues about that: #236, #293.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants