fix: spreading style is not consistent with attribute #15323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e52b534 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
dummdidumm
reviewed
Feb 18, 2025
| @@ -224,15 +224,17 @@ export function set_custom_element_data(node, prop, value) { | |||
| set_active_effect(null); | |||
| try { | |||
| if ( | |||
| // style need set_attribute() | |||
| prop !== 'style' && | |||
There was a problem hiding this comment.
If that is necessary, was it reall inconsistent before? Also see my question in the related issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we pass the style value directly,
set_attribute()is used.But with spreading, it was set by an assign on
element.style.cssText(ornode[prop]for custom-element).This cause the text to be parsed/corrected by the browser, and the value of the attribute will be different.
With this fix, spreading also use
set_attribute()for style.Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.packages/svelte/src, add a changeset (npx changeset).Tests and linting
pnpm testand lint the project withpnpm lint