'Real16': undeclared identifier

[SunBlack]

I tried to update the vcpkg package to 1.7.0, but there we get:

...\support\cpp_interface\libics.cpp(103): error C2838: 'Real16': illegal qualified name in member declaration
...\support\cpp_interface\libics.cpp(103): error C2065: 'Real16': undeclared identifier
...\support\cpp_interface\libics.cpp(152): error C2838: 'Real16': illegal qualified name in member declaration
...\support\cpp_interface\libics.cpp(152): error C2065: 'Real16': undeclared identifier
...\support\cpp_interface\libics.cpp(152): error C2051: case expression not constant

The value is missing here:

libics/support/cpp_interface/libics.hpp

Lines 74 to 88 in b754b63

	enum class DataType {
	Unknown = 0,
	UInt8, // integer, unsigned, 8 bpp
	SInt8, // integer, signed, 8 bpp
	UInt16, // integer, unsigned, 16 bpp
	SInt16, // integer, signed, 16 bpp
	UInt32, // integer, unsigned, 32 bpp
	SInt32, // integer, signed, 32 bpp
	UInt64, // integer, unsigned, 64 bpp
	SInt64, // integer, signed, 64 bpp
	Real32, // real, signed, 32 bpp
	Real64, // real, signed, 64 bpp
	Complex32, // complex, signed, 2*32 bpp
	Complex64 // complex, signed, 2*64 bpp
	};

Since I don't know where Real16 would be relevant, I didn't want to just insert it via a vcpkg patch.

[svi-os]

Support for 16-bits non-complex floating-point numbers, also known as "half floats", which are called Ics_real16 in the C implementation, was added in version 1.7.0. This is the Ics_real16 line in the enum Ics_DataType in libics.h:

/* These are the known data types for imels. If you use another type, you can't
use the top-level functions: /
typedef enum {
Ics_unknown = 0,
Ics_uint8, / integer, unsigned, 8 bpp /
Ics_sint8, / integer, signed, 8 bpp /
Ics_uint16, / integer, unsigned, 16 bpp /
Ics_sint16, / integer, signed, 16 bpp /
Ics_uint32, / integer, unsigned, 32 bpp /
Ics_sint32, / integer, signed, 32 bpp /
Ics_uint64, / integer, unsigned, 64 bpp /
Ics_sint64, / integer, signed, 64 bpp /
Ics_real16, / real, signed, 16 bpp /
Ics_real32, / real, signed, 32 bpp /
Ics_real64, / real, signed, 64 bpp /
Ics_complex32, / complex, signed, 232 bpp /
Ics_complex64 / complex, signed, 264 bpp */
} Ics_DataType;

We did not realize that this would require equivalent addition of the data type for the C++ interface.
SVI can address this in January.

[svi-os]

We already made the modifications in the C++ support for the C datatype Ics_real16, but missed the missing Real16 one in the libics.hpp because the C++ support is compiled by default with the CMake build system but not with the Autotools configure + make built system. We added the missing line now, to be included in the 1.7.1 release.