Skip to content

Commit 8a679ed

Browse files
committed
Refactoring - Extract Socket Trait
1 parent 7b92263 commit 8a679ed

File tree

6 files changed

+29
-19
lines changed

6 files changed

+29
-19
lines changed

src/Checks/Network/Tcp.php

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,14 @@
22
namespace Health\Checks\Network;
33

44
use Health\Checks\HealthCheckInterface;
5+
use Health\Checks\BaseCheck;
6+
use Health\Checks\Traits\SocketTrait;
57

6-
class Tcp extends Socket implements HealthCheckInterface
8+
class Tcp extends BaseCheck implements HealthCheckInterface
79
{
810

11+
use SocketTrait;
12+
913
/**
1014
*
1115
* {@inheritdoc}

src/Checks/Network/Tcp6.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,12 @@
22
namespace Health\Checks\Network;
33

44
use Health\Checks\HealthCheckInterface;
5+
use Health\Checks\BaseCheck;
6+
use Health\Checks\Traits\SocketTrait;
57

6-
class Tcp6 extends Socket implements HealthCheckInterface
8+
class Tcp6 extends BaseCheck implements HealthCheckInterface
79
{
10+
use SocketTrait;
811

912
/**
1013
*

src/Checks/Network/Udp.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,12 @@
22
namespace Health\Checks\Network;
33

44
use Health\Checks\HealthCheckInterface;
5+
use Health\Checks\BaseCheck;
6+
use Health\Checks\Traits\SocketTrait;
57

6-
class Udp extends Socket implements HealthCheckInterface
8+
class Udp extends BaseCheck implements HealthCheckInterface
79
{
10+
use SocketTrait;
811

912
/**
1013
*

src/Checks/Network/Udp6.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,12 @@
22
namespace Health\Checks\Network;
33

44
use Health\Checks\HealthCheckInterface;
5+
use Health\Checks\BaseCheck;
6+
use Health\Checks\Traits\SocketTrait;
57

6-
class Udp6 extends Socket implements HealthCheckInterface
8+
class Udp6 extends BaseCheck implements HealthCheckInterface
79
{
10+
use SocketTrait;
811

912
/**
1013
*

src/Checks/Network/Unix.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,12 @@
22
namespace Health\Checks\Network;
33

44
use Health\Checks\HealthCheckInterface;
5+
use Health\Checks\BaseCheck;
6+
use Health\Checks\Traits\SocketTrait;
57

6-
class Unix extends Socket implements HealthCheckInterface
8+
class Unix extends BaseCheck implements HealthCheckInterface
79
{
10+
use SocketTrait;
811

912
/**
1013
*

src/Checks/Network/Socket.php renamed to src/Checks/Traits/SocketTrait.php

Lines changed: 8 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,23 @@
11
<?php
2-
namespace Health\Checks\Network;
2+
namespace Health\Checks\Traits;
33

4-
use Health\Checks\BaseCheck;
5-
use Health\Checks\HealthCheckInterface;
6-
7-
class Socket extends BaseCheck implements HealthCheckInterface
4+
trait SocketTrait
85
{
96

10-
protected $resource = null;
11-
127
/**
8+
* Socket resource
139
*
14-
* {@inheritdoc}
15-
* @see \Health\Checks\HealthCheckInterface::call()
10+
* @var resource
1611
*/
17-
public function call()
18-
{
19-
return null;
20-
}
12+
protected $resource = null;
2113

2214
/**
2315
*
2416
* @param int $domain
2517
* @param int $type
2618
* @param int $protocol
19+
*
20+
* @return resource
2721
*/
2822
protected function create($domain, $type, $protocol)
2923
{
@@ -61,7 +55,7 @@ protected function connect($address)
6155
}
6256

6357
/**
64-
* Close Socket
58+
* Close SocketTrait
6559
*/
6660
protected function close()
6761
{

0 commit comments

Comments
 (0)