Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookkeeping verification page #3455

Open
JobDoesburg opened this issue Oct 26, 2023 · 4 comments
Open

Bookkeeping verification page #3455

JobDoesburg opened this issue Oct 26, 2023 · 4 comments
Labels
app:events Issues regarding the events-app app:moneybirdsynchronization Issues regarding the Moneybird synchronization app:payments Issues regarding the payments-app app:pizzas Issues regarding the pizzas-app app:registrations Issues regarding registrations app:sales Issues regarding the sales-app feature Issues regarding a complete new feature priority: low Should be dealt with when nothing else remains. request-for-comments Author wants to have other people respond for their opinion

Comments

@JobDoesburg
Copy link
Contributor

What?

There are some important things that are important to check for bookkeeping purposes:

  • A list of unpaid payables (unpaid event registrations where the event was in the past, unpaid sales orders of closed shifts, something with memberships)
  • A list of unsynced payments or payables (that aren't synced to moneybird)

It would be nice to create a simple page that displays this.

Why?

Audits

How?

@JobDoesburg JobDoesburg added priority: low Should be dealt with when nothing else remains. feature Issues regarding a complete new feature app:events Issues regarding the events-app app:pizzas Issues regarding the pizzas-app app:registrations Issues regarding registrations app:payments Issues regarding the payments-app request-for-comments Author wants to have other people respond for their opinion app:sales Issues regarding the sales-app app:moneybirdsynchronization Issues regarding the Moneybird synchronization labels Oct 26, 2023
@DeD1rk
Copy link
Member

DeD1rk commented Oct 26, 2023

list of unpaid payables

I think we create invoices for all payables that we expect to be paid some time (everything except unpaid sales orders and unpaid registrations). Unpaid registrations are not processed, and in sales there is the assumption that something is also only 'sold' once it's been paid: unpaid orders are deleted once the shift is closed.
So if I understand correctly the only 'unpaid but is actually revenue' payables are eventregistrations, for which invoices are created anyway. So then they already appear as 'still has to be paid' on moneybird.

list of unsynced payments or payables

From the admin, it's now (or tomorrow) easy to filter on invoices that need to be resynchronised. Of course that doesn't cover thing for which no invoice exists yet. But if we increase the sync frequency, or even schedule pushed in the background on post_save signals, I reckon there's probably no need to make an overview for those things that will be pushed really soon?

So do we really need something in concrexit for this? I have a feeling that everything you need should be in moneybird already.

@JobDoesburg
Copy link
Contributor Author

JobDoesburg commented Oct 26, 2023

I agree that if everything goes alright, all should be fine. This page is mainly here to detect what's going wrong. But indeed, if the moneybird sync is stable, we should be fine.

Maybe an integrity check (check if all moneybird id's actually exist in mb, etc) could be nice

@DeD1rk
Copy link
Member

DeD1rk commented Oct 27, 2023

Yeah if moneybird sync is buggy, having a page with pretty much the same queries copied from the synchronzation is unlikely to be any more correct.

check if all moneybird id's actually exist in mb

That would be nice yes. And isn't too hard with the synchronization endpoints. We could mark any incorrect/missing invoices and payments with a flag and just filter on them in the admin.

@JobDoesburg
Copy link
Contributor Author

Basically, a management command would suffice, only it would be nice if the output were to be web accessible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:events Issues regarding the events-app app:moneybirdsynchronization Issues regarding the Moneybird synchronization app:payments Issues regarding the payments-app app:pizzas Issues regarding the pizzas-app app:registrations Issues regarding registrations app:sales Issues regarding the sales-app feature Issues regarding a complete new feature priority: low Should be dealt with when nothing else remains. request-for-comments Author wants to have other people respond for their opinion
Projects
None yet
Development

No branches or pull requests

2 participants