Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork django-thumbnails? #3637

Open
DeD1rk opened this issue Mar 11, 2024 · 2 comments
Open

Fork django-thumbnails? #3637

DeD1rk opened this issue Mar 11, 2024 · 2 comments
Labels
chore Something that is not a bug or a feature, does not change production behaviour priority: low Should be dealt with when nothing else remains. security Security related issues

Comments

@DeD1rk
Copy link
Member

DeD1rk commented Mar 11, 2024

What?

I think we should maybe fork django-thumbnails, as it's not being maintained.

Why?

Then we can swap out its image processing library ('davinci') for pure Pillow, allowing us to use an up-to-date Pillow version. And we can just make it a bit nicer in general.

How?

Make a fork in svthalia, get rid of davinci, specify a newer Pillow dependency range, move our own fetch_thumbnails function into it, etc.

We can just install it with a public git url, no need to distribute to PyPI (yet) for our usecase.

@DeD1rk DeD1rk added priority: maybe someday This is not really relevant, but if we have nothing else to do, then we can think about this. request-for-comments Author wants to have other people respond for their opinion security Security related issues chore Something that is not a bug or a feature, does not change production behaviour labels Mar 11, 2024
@DeD1rk DeD1rk added priority: high Must be dealt with before the next release is deployed. and removed priority: maybe someday This is not really relevant, but if we have nothing else to do, then we can think about this. labels May 29, 2024
@DeD1rk
Copy link
Member Author

DeD1rk commented May 29, 2024

It seems that the old pillow version required by davinci doesn't run (it installs but crashes at runtime) on M1 macs (haven't verified that the latest version works at runtime but I assume so).

That's a pretty good reason to get rid of it.

@DeD1rk DeD1rk added priority: low Should be dealt with when nothing else remains. and removed request-for-comments Author wants to have other people respond for their opinion priority: high Must be dealt with before the next release is deployed. labels May 29, 2024
@DeD1rk
Copy link
Member Author

DeD1rk commented Jun 1, 2024

Update: actually, davinci supposedly should support Pillow 10 now. So there's no need to do it for that. But still worthwhile just to get some more control over it and merge e.g. our fetch_thumbnails improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Something that is not a bug or a feature, does not change production behaviour priority: low Should be dealt with when nothing else remains. security Security related issues
Projects
None yet
Development

No branches or pull requests

1 participant