Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have functionality to show the current configuration #90

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tngraf
Copy link
Collaborator

@tngraf tngraf commented Oct 22, 2024

No description provided.

@tngraf tngraf added the enhancement New feature or request label Oct 22, 2024
@tngraf tngraf requested a review from gernot-h October 22, 2024 09:58
@tngraf tngraf linked an issue Oct 22, 2024 that may be closed by this pull request
@gernot-h
Copy link
Collaborator

Hi @tngraf, thanks for assigning me for review here!

I assume this is only a draft and you ask for my general opinion about adding "config list"? I see a number of small issues like missing help entry, copy&paste inconsistencies etc. which I shouldn't review yet, right?

I'm still a bit undecided whether we need an own subcommand or if it would be better to add some debug output to process_cmdline instead.

In general, I'm still a bit confused about the config file feature, I think we should add some documentation e.g. about its format and in which paths capycli expects it on Linux and Windows?

On the other hand, having something like "capycli config create" might be handy, creating a self-documenting example file for you, might probably be even better than adding long Readme discussions.

@gernot-h
Copy link
Collaborator

Regarding the implementation, I would avoid duplicating the config file read code in config/list.py and probably better add the output in main/options.py (independent whether it's triggered via enabling verbose or debug output or via a special command) , so we don't risk that the implementation in config/list.py gets inconsistent to the main one and provide wrong information to the user in corner cases...

@gernot-h gernot-h marked this pull request as draft October 23, 2024 07:29
@gernot-h gernot-h assigned tngraf and unassigned gernot-h Oct 23, 2024
@gernot-h
Copy link
Collaborator

Reassigning back to you, @tngraf for further discussion. I could also work on improving this if you want!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Have functionality to show the (currrent) configuration
3 participants