Merge pull request #45 from epandurski/master

Add a todo, do not pass x-message-ttl argument when creating queues

Author: epandurski

development.env

@@ -48,5 +48,5 @@ SUBSTITUTE_LOCALHOST_IN_VARS=PROTOCOL_BROKER_URL
 # should not be used in production!                        #
 ############################################################
 
-RABBITMQ_VERSION=3.8.11-management-alpine
+RABBITMQ_VERSION=3.13.6-management-alpine
 RABBITMQ_MANAGEMENT_LOCAL_PORT=15676

swpt_stomp/configure_queue.py

@@ -137,19 +137,23 @@ async def bind_queue() -> None:
 
         # Declare the requested queue along with its corresponding
         # dead-letter queue, and bind it to the peer exchange.
+        #
+        # TODO: It would probably be better to use a "stream" instead
+        #       of classic queues here, given that we have figured out
+        #       how to do the stream offset tracking. This would allow
+        #       for high-availability. Using a "quorum" queues here is
+        #       almost certainly not a good idea, because quorum
+        #       queues consume lots of memory when there are lots of
+        #       messages in the queue, which should be expected.
         dead_letter_queue_name = queue_name + ".XQ"
         await channel.declare_queue(
             dead_letter_queue_name,
             durable=True,
-            arguments={
-                "x-message-ttl": 604800000,
-            },
         )
         queue = await channel.declare_queue(
             queue_name,
             durable=True,
             arguments={
-                "x-message-ttl": 604800000,
                 "x-dead-letter-exchange": "",
                 "x-dead-letter-routing-key": dead_letter_queue_name,
             },