Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate that "failure conditions" are "optional" objectives #1347

Open
kostmo opened this issue Jun 25, 2023 · 2 comments
Open

Validate that "failure conditions" are "optional" objectives #1347

kostmo opened this issue Jun 25, 2023 · 2 comments
Labels
G-Scenarios An issue having to do with scenario design, the way scenarios are described and loaded, etc. S-Nice to have The bug fix or feature would be nice but doesn't currently have much negative impact. T-Challenges Involves the challenge scenarios - shorter games with objectives. Z-CI This issue is about continuous integration pipelines - GH Actions - tests and releases on server. Z-Developer Experience This issue seeks to make life easier for developers writing Scenarios or other Swarm code. Z-Feature A new feature to be added to the game.

Comments

@kostmo
Copy link
Member

kostmo commented Jun 25, 2023 •
edited
Loading

All objectives that are negated prerequisites of required goals should themselves be optional. Otherwise, it is impossible to win!

This pitfall burned some time while debugging failing integration tests for #1342, which has a single "not" prerequisite on submitting the "wrong answer". Fixing the test was as simple as setting optional: true on that prerequisite, but discovering the oversight was not straightforward.

Having a more direct way to express "failure conditions" (#1046) may be related to this.

Code pointers:
@kostmo kostmo added Z-Feature A new feature to be added to the game. G-Scenarios An issue having to do with scenario design, the way scenarios are described and loaded, etc. Z-Developer Experience This issue seeks to make life easier for developers writing Scenarios or other Swarm code. labels Jun 25, 2023
@kostmo
Copy link
Member Author

kostmo commented Dec 6, 2023

Also related: #1628 (comment)

@byorgey byorgey added Z-CI This issue is about continuous integration pipelines - GH Actions - tests and releases on server. S-Nice to have The bug fix or feature would be nice but doesn't currently have much negative impact. T-Challenges Involves the challenge scenarios - shorter games with objectives. labels Dec 12, 2023
@byorgey
Copy link
Member

byorgey commented Oct 1, 2024

Are optional objectives marked in the UI in some way, or is it a purely internal flag that affects how we determine when a scenario has been completed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
G-Scenarios An issue having to do with scenario design, the way scenarios are described and loaded, etc. S-Nice to have The bug fix or feature would be nice but doesn't currently have much negative impact. T-Challenges Involves the challenge scenarios - shorter games with objectives. Z-CI This issue is about continuous integration pipelines - GH Actions - tests and releases on server. Z-Developer Experience This issue seeks to make life easier for developers writing Scenarios or other Swarm code. Z-Feature A new feature to be added to the game.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kostmo @byorgey