Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(es/ast): Box ArrayPat and ObjectPat #10104

Draft
wants to merge 26 commits into
base: main
Choose a base branch
from
Draft

perf(es/ast): Box ArrayPat and ObjectPat #10104

wants to merge 26 commits into from

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Feb 26, 2025

Description:

These are relatively rare compared to identifier patterns, and more importantly, these types increase the size of the Expr type. So this PR moves them to the Box.

Copy link

changeset-bot bot commented Feb 26, 2025

🦋 Changeset detected

Latest commit: 534b1af

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member Author

kdy1 commented Feb 26, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@kdy1 kdy1 changed the title fix(es/ts_strip): Handle ASI hazard in return statement (#9882) perf(es/ast): Box ArrayPat and ObjectPat Feb 26, 2025
@kdy1 kdy1 added this to the Planned milestone Feb 26, 2025
@kdy1 kdy1 self-assigned this Feb 26, 2025
@kdy1 kdy1 marked this pull request as ready for review February 27, 2025 01:17
@kdy1 kdy1 requested review from a team as code owners February 27, 2025 01:17
kodiakhq[bot]
kodiakhq bot previously approved these changes Feb 27, 2025
Copy link

codspeed-hq bot commented Feb 27, 2025

CodSpeed Performance Report

Merging #10104 will degrade performances by 7.44%

Comparing kdy1/ast-1 (f1381a1) with main (e74929c)

Summary

⚡ 2 improvements
❌ 4 regressions
✅ 185 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
es/full/minify/libraries/lodash 187.3 ms 197.2 ms -5%
es/lints/libs/antd 225.7 ms 218.4 ms +3.33%
es/lints/libs/moment 5.4 ms 5.9 ms -7.44%
es/lints/libs/victory 101.1 ms 106.2 ms -4.81%
es/minifier/libs/jquery 132.4 ms 138.2 ms -4.2%
es/transform/baseline/common_reserved_word 290.8 µs 279.2 µs +4.18%

@kdy1 kdy1 marked this pull request as draft February 27, 2025 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant