Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(es/minifier): Improve arrow function inlining cost analysis #10093

Merged
merged 8 commits into from
Feb 26, 2025

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Feb 25, 2025

Description:

This PR fixes the cost analysis of arrow functions by making it use Option<u8> instead of bool.

Copy link

changeset-bot bot commented Feb 25, 2025

⚠️ No Changeset found

Latest commit: eac8344

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kdy1 kdy1 self-assigned this Feb 25, 2025
@kdy1 kdy1 force-pushed the kdy1/minifier-cost-fix branch from 4ceb761 to b6881ce Compare February 25, 2025 07:34
@kdy1 kdy1 force-pushed the kdy1/minifier-consider-cost branch from f5e2d40 to 80298d5 Compare February 25, 2025 07:34
@kdy1 kdy1 changed the title inline cost perf(es/minifier): Improve arrow function inlining cost analysis Feb 25, 2025
@kdy1 kdy1 marked this pull request as ready for review February 25, 2025 07:37
@kdy1 kdy1 requested a review from a team as a code owner February 25, 2025 07:37
@kdy1 kdy1 added this to the Planned milestone Feb 25, 2025
@kdy1 kdy1 force-pushed the kdy1/minifier-cost-fix branch from b6881ce to 32e7dd9 Compare February 25, 2025 07:38
@kdy1 kdy1 force-pushed the kdy1/minifier-consider-cost branch 3 times, most recently from 847a04f to 9d77a6b Compare February 25, 2025 07:44
@kdy1 kdy1 force-pushed the kdy1/minifier-cost-fix branch from 2c63872 to 9aded2c Compare February 25, 2025 08:01
@kdy1 kdy1 requested a review from a team as a code owner February 25, 2025 08:01
@kdy1 kdy1 force-pushed the kdy1/minifier-consider-cost branch from 9d77a6b to 6d70e81 Compare February 25, 2025 08:02
@kdy1 kdy1 force-pushed the kdy1/minifier-cost-fix branch 2 times, most recently from 5932a32 to b115686 Compare February 25, 2025 08:37
@kdy1 kdy1 force-pushed the kdy1/minifier-consider-cost branch from 6d70e81 to 11e9e5c Compare February 25, 2025 08:37
Copy link

codspeed-hq bot commented Feb 25, 2025

CodSpeed Performance Report

Merging #10093 will degrade performances by 4.17%

Comparing kdy1/minifier-consider-cost (7e020de) with main (1425b56)

Summary

⚡ 2 improvements
❌ 1 regressions
✅ 188 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
es/full/minify/libraries/lodash 188.2 ms 196.4 ms -4.17%
es/minifier/libs/d3 525.3 ms 509 ms +3.2%
es/minifier/libs/lodash 158.2 ms 153.1 ms +3.32%

@kdy1 kdy1 force-pushed the kdy1/minifier-cost-fix branch from b115686 to ad3eb13 Compare February 26, 2025 02:49
@kdy1 kdy1 force-pushed the kdy1/minifier-consider-cost branch from 11e9e5c to 6305358 Compare February 26, 2025 02:49
@kdy1 kdy1 changed the base branch from kdy1/minifier-cost-fix to graphite-base/10093 February 26, 2025 12:25
@kdy1 kdy1 force-pushed the graphite-base/10093 branch from ad3eb13 to 1425b56 Compare February 26, 2025 12:26
@kdy1 kdy1 force-pushed the kdy1/minifier-consider-cost branch from 6305358 to 6e87e5a Compare February 26, 2025 12:26
@kdy1 kdy1 changed the base branch from graphite-base/10093 to main February 26, 2025 12:26
@kdy1 kdy1 force-pushed the kdy1/minifier-consider-cost branch from 6e87e5a to 595b301 Compare February 26, 2025 12:26
kodiakhq[bot]
kodiakhq bot previously approved these changes Feb 26, 2025
kodiakhq[bot]
kodiakhq bot previously approved these changes Feb 26, 2025
@kdy1 kdy1 merged commit e74929c into main Feb 26, 2025
172 checks passed
Copy link
Member Author

kdy1 commented Feb 26, 2025

Merge activity

  • Feb 26, 10:13 PM GMT+9: A user merged this pull request with Graphite.

@kdy1 kdy1 deleted the kdy1/minifier-consider-cost branch February 26, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant