Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure plot elements are not truncated #650

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Simon-Stone
Copy link

Fixes #638 by adding calls to tight_layout to the respective solution.

@github-actions
Copy link

github-actions bot commented Jun 6, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/swcarpentry/python-novice-gapminder/compare/md-outputs..md-outputs-PR-650

The following changes were observed in the rendered markdown documents:

 09-plotting.md | 10 +++++++++-
 md5sum.txt     |  2 +-
 2 files changed, 10 insertions(+), 2 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-03-17 08:41:02 +0000

github-actions bot pushed a commit that referenced this pull request Jun 7, 2023
@martinosorb
Copy link
Contributor

It looks good to me but I'd like opinions from other maintainers before merging.

@alee
Copy link
Member

alee commented Jul 24, 2023

I think it's a good addition as well. Only thing a bit leery of is the caveat in the docs This is an experimental feature and may not work for some cases. It only checks the extents of ticklabels, axis labels, and titles. if that's still true.

We could also consider changing the example code to use constrained layouts instead?

github-actions bot pushed a commit that referenced this pull request Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

savefig truncates figure elements
3 participants