Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A better way to begin Lesson 3 #468

Open
yuanxiesa opened this issue Feb 29, 2020 · 3 comments
Open

A better way to begin Lesson 3 #468

yuanxiesa opened this issue Feb 29, 2020 · 3 comments

Comments

@yuanxiesa
Copy link

Hi, I suggest removing the example of the "analyze" function at the very beginning. The reason is that I found the second example (function "print_words") is a more straight-forward and compelling example to demonstrate the limitation of hard-coding and the value of loops to the learners. I understand putting the "analyze" function at the beginning may show the continuity. But in practice, it is just not a powerful example and risks losing learners' attention.

Thanks!

@HaoZeke
Copy link
Member

HaoZeke commented Mar 27, 2020

Hi. Thanks for the suggestion. Do you think reworking the analyze function to use mfrow to make the example shorter might help? The idea is to have a motivating example, but it is true that the current form is visually noisy.

In an actual workshop the instructors would probably gloss over the analyze function itself at this stage.

@maria-pro
Copy link

HaoZeke,

I believe it is not the use of the function itself but rather the task itself and moreover the question it is linked to - the wording does not play nicely with the previous lesson, #2

How can I do the same thing to multiple data sets?

The notion of "function" is already introduced, so why not use it?

A possible change can be:

What do I do if I have different data sets, but need to repeat the same steps?

How can I apply a function to different data sets

Some sort of introductory sentence is also needed there at the start:

As we saw in the previous lesson, performing same steps again and again can be a routine task created as a function. One of such routine tasks can be performing the same analysis on different datasets

@HaoZeke
Copy link
Member

HaoZeke commented Apr 10, 2020

Thank you for the clarifications! I think your changes make a lot of sense, would you be willing to put them in a PR?

fmichonneau pushed a commit that referenced this issue Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants