-
-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exercise timing missing for analyzing patient data #519
Comments
Sure, that's a great catch, thanks for bringing it up! Would you be willing to open a PR for the same? |
Yes, do those timings seem reasonable to you? I.e. 10-15 mins. I haven't actually taught this episode so unsure how long it takes in real life. |
Yup, I've personally never spent longer than ten minutes but 10-15 sounds perfect. :) |
I went to open a PR and noticed that exercise time is also missing from other episodes e.g. http://swcarpentry.github.io/r-novice-inflammation/02-func-R/index.html. It might be worth someone going through all the lessons to check, but I didn't yet have time. Also, changing these will require updating the home page (http://swcarpentry.github.io/r-novice-inflammation/) to update the timings, but I wasn't able to work out how to do this or whether it is done automatically. |
I noticed the same thing, It looks like every episode in the lesson has 0 mins for exercises.
I'd also echo the question about whether the timings on the main page are updated manulally or automatically for this. |
Hi @ubdbra001. Thanks for going over these, the timings look great. I can't recall at the moment if they are updated or not, we can deal with that in a separate PR. Please go ahead with the timings from lesson 2 onwards. @worcjamessmith It would be good to have a PR relating to the first lesson :) |
Great will do! |
Hi @worcjamessmith & @ubdbra001, thanks again for catching this and offering to fix it. Are you still interested and available to submit pull requests for this? We're always happy to let people contribute directly but if it doesn't work for you, I can integrate the changes myself and mark you as co-authors of the changes. |
Fix #519 Co-authored-by: worcjamessmith <worcjamessmith@users.noreply.github.com> Co-authored-by: Dan Brady <ubdbra001@users.noreply.github.com>
Fix #519 Co-authored-by: worcjamessmith <worcjamessmith@users.noreply.github.com> Co-authored-by: Dan Brady <ubdbra001@users.noreply.github.com>
The first episode in the programming with R lesson (http://swcarpentry.github.io/r-novice-inflammation/01-starting-with-data/index.html) states that the time for exercises is 0 minutes. However, there are several exercises that I expect would take about 10-15 minutes to complete. Should the exercise timing be updated?
The text was updated successfully, but these errors were encountered: