Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support swift-service-lifecycle #374

Open
fabianfett opened this issue Sep 27, 2024 · 1 comment
Open

Add support swift-service-lifecycle #374

fabianfett opened this issue Sep 27, 2024 · 1 comment
Assignees
Labels
area/documentation Improvements or additions to documentation. good first issue Good for newcomers semver/none No version bump required. size/S Small task. (A couple of hours of work.) status/blocked Waiting for another issue.
Milestone

Comments

@fabianfett
Copy link
Member

fabianfett commented Sep 27, 2024

The code on the main branch currently does not support Swift Service Lifecycle.

@fabianfett fabianfett added this to the 2.0 milestone Sep 27, 2024
@sebsto sebsto self-assigned this Sep 27, 2024
@sebsto sebsto added area/documentation Improvements or additions to documentation. good first issue Good for newcomers semver/none No version bump required. status/needs-design Needs further discussion and a concrete proposal. size/S Small task. (A couple of hours of work.) labels Jan 4, 2025
@sebsto sebsto changed the title swift-service-lifecycle example & docc (use Postgres) Ass support swift-service-lifecycle Jan 12, 2025
@sebsto sebsto changed the title Ass support swift-service-lifecycle Add support swift-service-lifecycle Jan 12, 2025
@sebsto
Copy link
Contributor

sebsto commented Jan 12, 2025

We started the implementation with these two PR

  • #459 : make LambdaRuntimeClient.nextInvocation() cancellable
  • #456 : Add LambdaRuntimService and an example function

These two PR have unresolved issues.

  • #459 is not Swift 6 compliant
/swift/lambda/swift-aws-lambda-runtime/Sources/AWSLambdaRuntimeCore/LambdaRuntimeClient.swift:343:38: warning: sending 'handler' risks causing data races; this is an error in the Swift 6 language mode
341 |                 defer {
342 |                     for continuation in array {
343 |                         continuation.resume(returning: handler)
    |                                      |- warning: sending 'handler' risks causing data races; this is an error in the Swift 6 language mode
    |                                      `- note: 'self'-isolated 'handler' is passed as a 'sending' parameter; Uses in callee may race with later 'self'-isolated uses
344 |                     }
345 |                 }
  • #456 adds partial support for graceful shutdown. But the graceful shutdown flag is not propagated down to the LambdaRuntimeClient. Currently, this call cannot be interrupted when a graceful shutdown is requested.

@sebsto sebsto added status/blocked Waiting for another issue. and removed status/needs-design Needs further discussion and a concrete proposal. labels Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation. good first issue Good for newcomers semver/none No version bump required. size/S Small task. (A couple of hours of work.) status/blocked Waiting for another issue.
Projects
None yet
Development

No branches or pull requests

2 participants