Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a CI job that tests that we don't like full Foundation #402

Closed
fabianfett opened this issue Oct 9, 2024 · 2 comments
Closed

Create a CI job that tests that we don't like full Foundation #402

fabianfett opened this issue Oct 9, 2024 · 2 comments
Milestone

Comments

@fabianfett
Copy link
Member

Expected behavior

We should have a CI job that validates that we don't link full Foundation and only link FoundationEssentials.

Actual behavior

N/A

Steps to reproduce

N/A

If possible, minimal yet complete reproducer code (or URL to code)

No response

What version of this project (swift-aws-lambda-runtime) are you using?

N/A

Swift version

N/A

Amazon Linux 2 docker image version

No response

@sebsto
Copy link
Contributor

sebsto commented Dec 18, 2024

Work in progress on the event library
swift-server/swift-aws-lambda-events#81

sebsto added a commit that referenced this issue Dec 25, 2024
#441)

This adds a test in the `integration_test.yml` workflow to verify that
`libFoundation.so`, `libFoundationInternationalization.so`, and
`lib_FoundationICU.so` and not linked the the function binary.

This is a follow up from the work make by @t089 to ensure that we don't
accidentally link Foundation again in the future.

Remove Foundation :
#436
Add test in CI to ensure we don't link to foundation :
#402
@sebsto
Copy link
Contributor

sebsto commented Dec 25, 2024

Fixed by #441

@sebsto sebsto closed this as completed Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants