Skip to content

Commit 295785b

Browse files
committed
Add log statements to troubleshoot failing test in CI
1 parent 2791737 commit 295785b

File tree

2 files changed

+14
-8
lines changed

2 files changed

+14
-8
lines changed

Tests/SwiftkubeClientTests/K3dConfigMapTests.swift

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
// limitations under the License.
1515
//
1616

17+
import Logging
1718
import SwiftkubeClient
1819
import SwiftkubeModel
1920
import XCTest
@@ -86,7 +87,7 @@ final class K3dConfigMapTests: K3dTestCase {
8687

8788
func testWatch() {
8889
let expectedRecords = expectation(description: "Expected Records")
89-
let watcher = Watcher(excpectation: expectedRecords, expectedCount: 5)
90+
let watcher = Watcher(logger: K3dConfigMapTests.logger, expectation: expectedRecords, expectedCount: 5)
9091

9192
let task = try? K3dTestCase.client.configMaps.watch(in: .namespace("cm3"), delegate: watcher)
9293

@@ -95,7 +96,7 @@ final class K3dConfigMapTests: K3dTestCase {
9596
_ = try? K3dTestCase.client.configMaps.delete(inNamespace: .namespace("cm3"), name: "test1").wait()
9697
_ = try? K3dTestCase.client.configMaps.update(inNamespace: .namespace("cm3"), buildConfigMap("test2", data: ["foo": "bar"])).wait()
9798

98-
wait(for: [watcher.excpectedRecords], timeout: 5)
99+
wait(for: [watcher.expectedRecords], timeout: 30)
99100
task?.cancel()
100101

101102
assertEqual(watcher.records, [
@@ -121,24 +122,26 @@ final class K3dConfigMapTests: K3dTestCase {
121122
let resource: String
122123
}
123124

124-
let excpectedRecords: XCTestExpectation
125+
let logger: Logger
126+
let expectedRecords: XCTestExpectation
125127
var expectedCount: Int
126128
var records: [Record] = []
127129

128-
init(excpectation: XCTestExpectation, expectedCount: Int) {
129-
self.excpectedRecords = excpectation
130+
init(logger: Logger, expectation: XCTestExpectation, expectedCount: Int) {
131+
self.logger = logger
132+
self.expectedRecords = expectation
130133
self.expectedCount = expectedCount
131134
}
132135

133136
func onEvent(event: EventType, resource: core.v1.ConfigMap) {
134137
records.append(Record(eventType: event, resource: resource.name!))
135138
if records.count == expectedCount {
136-
excpectedRecords.fulfill()
139+
expectedRecords.fulfill()
137140
}
138141
}
139142

140143
func onError(error: SwiftkubeClientError) {
141-
// NOOP
144+
logger.warning("Error encountered: \(error)")
142145
}
143146
}
144147
}

Tests/SwiftkubeClientTests/K3dTestCase.swift

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,16 +14,19 @@
1414
// limitations under the License.
1515
//
1616

17+
import Logging
1718
import SwiftkubeClient
1819
import SwiftkubeModel
1920
import XCTest
2021

2122
open class K3dTestCase: XCTestCase {
2223

24+
static var logger: Logger!
2325
static var client: KubernetesClient!
2426

2527
open override class func setUp() {
26-
client = KubernetesClient()!
28+
logger = Logger(label: "swiftkubeclient-test")
29+
client = KubernetesClient(logger: logger)!
2730
}
2831

2932
open override class func tearDown() {

0 commit comments

Comments
 (0)