AIS - add endpoints for camt052 reports and camt054 notifications (issue#126) #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
simonmeyerm
commented
Oct 11, 2024
simonmeyerm
commented
- New endpoint for list of camt.052 reports added
- New endpoint for retrieval of specific camt.052 reportIds added
- New schema "Iso20022ReportReference052" added
1 task
svenbiellmann
requested changes
Oct 25, 2024
dkoeni
force-pushed
the
126-enhancement-to-support-camt052-and-camt054-file-exchange-for-intraday-transaction-data-and-creditdebit-statements
branch
2 times, most recently
from
c1c8c27 to
21a39f0
Compare
dkoeni
force-pushed
the
126-enhancement-to-support-camt052-and-camt054-file-exchange-for-intraday-transaction-data-and-creditdebit-statements
branch
from
21a39f0 to
73e2b73
Compare
- Endpoint for camt.054 credit/debit notifications added
corrections lint findings
corrections lint validator
|
I have added a first draft of the camt.054 endpoint, which should serve as a first reference how it could look like. However, the proposal needs some improvements with regard to the usage of the booking identifiers and further descriptions. |
Update format for reportIds
accountAPI.yaml
Outdated
| - $ref: '#/components/parameters/optional_psu_user_agent_in_header' | ||
| responses: | ||
| '200': | ||
| description: Returns the requested ISO20022 XML camt.052 message. |
There was a problem hiding this comment.
@simonmeyerm In the description there's a type. camt.052 should be replaced by camt.054.
There was a problem hiding this comment.
Thank you for the review. Description is now adjusted
- Rework camt.054 endpoint - Remove accountId as parameter for camt.052 and camt.054 endpoint
lint corrections
- Adjusted structure with pagination to be aligned with statements endpoint
added required fields
removed acctsvcrref
simonmeyerm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.