From 0a91f2038e691d8c9aae67425027008fbfb270be Mon Sep 17 00:00:00 2001 From: Fabian Gut Date: Fri, 18 Aug 2023 15:10:17 +0200 Subject: [PATCH 1/2] SDCISA-12917 improvements to comply with standard apikana behaviour --- .../apikana/AbstractApikanaMojo.java | 32 ++++++++++++++++--- 1 file changed, 27 insertions(+), 5 deletions(-) diff --git a/apikana-maven-plugin/src/main/java/org/swisspush/apikana/AbstractApikanaMojo.java b/apikana-maven-plugin/src/main/java/org/swisspush/apikana/AbstractApikanaMojo.java index e7de29f..bc72e35 100644 --- a/apikana-maven-plugin/src/main/java/org/swisspush/apikana/AbstractApikanaMojo.java +++ b/apikana-maven-plugin/src/main/java/org/swisspush/apikana/AbstractApikanaMojo.java @@ -255,7 +255,7 @@ protected void generatePackageJson(String version) throws IOException { if (shortname != null && shortname.length() > 0) { customConfig.put("shortname", shortname); } - customConfig.put("projectName", mavenProject.getArtifactId()); + customConfig.put("projectName", getProjectName()); customConfig.put("title", getTitle(apiSpec)); final List plugins = new ArrayList<>(); @@ -351,14 +351,36 @@ private String getDescription(Map apiSpec) { return (String) info.get("description"); } + private String getProjectName() { + return String.join("-", this.shortname, this.type); + } + private String getName() { - String artifactId = mavenProject.getArtifactId(); + StringBuilder nameBuilder = new StringBuilder(); + + if (this.domain != null && this.domain.length() > 0) { + List domainParts = new ArrayList<>(Arrays.asList(this.domain.split("\\."))); + Collections.reverse(domainParts); + String nodeDomain = String.join("-", domainParts); + nameBuilder.append("@").append(nodeDomain); + } - if(scope.length() == 0) { - return artifactId; + if (this.namespace != null && this.namespace.length() > 0) { + String nodeNamespace = this.namespace + .replace(".", "-") + .replace("-" + this.shortname, ""); + + if (nameBuilder.length() == 0) { + nameBuilder.append("@"); + } else { + nameBuilder.append("-"); + } + nameBuilder.append(nodeNamespace).append("/"); } - return String.format("%s/%s", this.scope.startsWith("@") ? this.scope : "@" + this.scope, artifactId); + nameBuilder.append(getProjectName()); + + return nameBuilder.toString(); } protected void checkNodeInstalled() throws MojoExecutionException { From d314be76c670a9b2aae0c2b13ea1fa43a5d5c0da Mon Sep 17 00:00:00 2001 From: Fabian Gut Date: Fri, 18 Aug 2023 15:17:15 +0200 Subject: [PATCH 2/2] Update next release version --- .github/workflows/publish.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index 6e6bf07..15570d8 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -5,8 +5,8 @@ on: - master env: - RELEASE_VERSION: "0.4.22" - DEVELOP_VERSION: "0.4.23-SNAPSHOT" + RELEASE_VERSION: "0.4.23" + DEVELOP_VERSION: "0.4.24-SNAPSHOT" GIT_AUTHOR_NAME: "@swisspost-devs" GIT_AUTHOR_EMAIL: "oss@post.ch" GIT_COMMITTER_NAME: "swisspost-devs"