Trackable broadcast #708
Trackable broadcast #708
Conversation
|
Could you please create an issue describing the intention of this feature? I did not yet fully review the changes but I don't like the way the now every |
|
@mcweba I added a switch which can set by eventbus, default disabled. |
| RequestLogger.logRequest(vertx.eventBus(), request, status, buffer); | ||
| } | ||
| vertx.eventBus().publish(SAVE_LISTENER_ADDRESS, listenerStorageUri); | ||
| trackableEventPublish.publish(SAVE_LISTENER_ADDRESS, listenerStorageUri); |
There was a problem hiding this comment.
I assume it is by intent to DUPLICATE that publication here? All other places do a REPLACE of the call. Except this one, which now does TWO calls.
vertx.eventBus().publish(SAVE_LISTENER_ADDRESS, listenerStorageUri);
+ trackableEventPublish.publish(SAVE_LISTENER_ADDRESS, listenerStorageUri);There was a problem hiding this comment.
Thanks, I removed it already, but don't know it doesn't marked it as outdated
| if (body.containsKey(KEY_REPLY_ADDRESS)) { | ||
| String replyAddr = body.getString(KEY_REPLY_ADDRESS); | ||
| vertx.eventBus().send(replyAddr, null); | ||
| handler.handle(body.getString(KEY_DATA)); |
There was a problem hiding this comment.
I assume it is by intent to call
vertx.eventBus().send(replyAddr, null)
only if trackerEnabled == true?
There was a problem hiding this comment.
Yes, there 2 things need to check to use reply:
- function enabled
- there is a reply address attached.
because when trackerEnabled == true, may still received some events which published by other when tracker is not enabled yet
log gateleen key event consumer counter