Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor impl of Thread::getExitStatus()/Thread::isAlive() #5695

Merged
merged 4 commits into from
Feb 24, 2025

Conversation

matyhtf
Copy link
Member

@matyhtf matyhtf commented Feb 24, 2025

No description provided.

Copy link

codecov bot commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 72.22222% with 10 lines in your changes missing coverage. Please review.

Project coverage is 71.16%. Comparing base (d647b78) to head (66b515f).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/server/thread.cc 55.55% 8 Missing ⚠️
include/swoole_thread.h 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5695      +/-   ##
==========================================
+ Coverage   71.13%   71.16%   +0.02%     
==========================================
  Files         109      109              
  Lines       16845    16845              
  Branches     3077     3075       -2     
==========================================
+ Hits        11982    11987       +5     
+ Misses       4809     4804       -5     
  Partials       54       54              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matyhtf matyhtf merged commit 59d652a into master Feb 24, 2025
71 of 74 checks passed
@matyhtf matyhtf deleted the optimize-thread-exit-code branch February 24, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant