Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content retains in the preview panel #1702

Closed
TobisLee opened this issue Sep 29, 2024 · 8 comments · Fixed by #1704
Closed

Content retains in the preview panel #1702

TobisLee opened this issue Sep 29, 2024 · 8 comments · Fixed by #1704
Labels
bug Something isn't working

Comments

@TobisLee
Copy link
Contributor

What system are you running Yazi on?

Linux Wayland

What terminal are you running Yazi in?

kitty 0.36.4

yazi --debug output

Yazi
    Version: 0.3.3 (3e4973db 2024-09-27)
    Debug  : false
    OS     : linux-x86_64 (unix)

Ya
    Version: 0.3.3 (3e4973db 2024-09-27)

Emulator
    Emulator.via_env: ("xterm-kitty", "")
    Emulator.via_csi: Ok(Kitty)
    Emulator.detect : Kitty

Adapter
    Adapter.matches: Kitty

Desktop
    XDG_SESSION_TYPE           : Some("wayland")
    WAYLAND_DISPLAY            : Some("wayland-0")
    DISPLAY                    : Some(":0")
    SWAYSOCK                   : None
    HYPRLAND_INSTANCE_SIGNATURE: None
    WAYFIRE_SOCKET             : None

SSH
    shared.in_ssh_connection: false

WSL
    WSL: false

Variables
    SHELL              : Some("/usr/bin/fish")
    EDITOR             : Some("nvim")
    VISUAL             : Some("nvim")
    YAZI_FILE_ONE      : None
    YAZI_CONFIG_HOME   : None

Text Opener
    default: Some(Opener { run: "${EDITOR:-vi} \"$@\"", block: true, orphan: false, desc: "$EDITOR", for_: None, spread: true })
    block  : Some(Opener { run: "${EDITOR:-vi} \"$@\"", block: true, orphan: false, desc: "$EDITOR", for_: None, spread: true })

Multiplexers
    TMUX               : false
    tmux version       : 3.5
    ZELLIJ_SESSION_NAME: None
    Zellij version     : No such file or directory (os error 2)

Dependencies
    file             : 5.45
    ueberzugpp       : ExitStatus(unix_wait_status(32512)), "ueberzugpp: error while loading shared libraries: libfmt.so.10: cannot open shared object file: No such file or directory\n"
    ffmpegthumbnailer: 2.2.3
    magick           : 7.1.1-38
    fzf              : 0.55.0
    fd               : 10.2.0
    rg               : 14.1.1
    chafa            : 1.14.2
    zoxide           : 0.9.6
    7z               : 17.05
    7zz              : No such file or directory (os error 2)
    jq               : 1.7.1


--------------------------------------------------
When reporting a bug, please also upload the `yazi.log` log file - only upload the most recent content by time.
You can find it in the "/home/tlss/.local/state/yazi" directory.

Did you try the latest nightly build to see if the problem got fixed?

Yes, and I updated the debug information above (yazi --debug) to the nightly that I tried

Describe the bug

When I navigated to a specific file, then go to the parent folder, there are some characters retain in the preview panel.

屏幕截图_20240929_205259

Minimal reproducer

  1. Navigate to the specific file.
  2. Go to the parent folder.

Download the specific file here: https://bellard.org/ioccc_lena/img.h

Anything else?

No response

@TobisLee TobisLee added the bug Something isn't working label Sep 29, 2024
@sxyazi
Copy link
Owner

sxyazi commented Sep 29, 2024

I can't reproduce it using the steps you provided:

screenshot-002043.mp4

Did you use any custom configs/plugins? Can you reproduce it with the default config (mv ~/.config/yazi ~/.config/yazi-backup)?

Also I noticed you're not using the latest nightly version; can you reproduce it with the latest nightly?

Let me know if I missed any details for replicating it.

@sxyazi sxyazi added the waiting on op Waiting for more information from the original poster label Sep 29, 2024
@TobisLee
Copy link
Contributor Author

I add the following line in yazi.toml to see the preview

prepend_previewers = [
 { name = "*.h", run = "code" },
 { name = "*.c", run = "code" },
]

@github-actions github-actions bot removed the waiting on op Waiting for more information from the original poster label Sep 29, 2024
@sxyazi
Copy link
Owner

sxyazi commented Sep 29, 2024

Why not use the default code rules?

# Code
{ mime = "text/*", run = "code" },
{ mime = "*/{xml,javascript,x-wine-extension-ini}", run = "code" },

@TobisLee
Copy link
Contributor Author

the img.h file is treated as a data type, not in the default rule.

@sxyazi
Copy link
Owner

sxyazi commented Sep 29, 2024

I can reproduce it with your custom config, will investigate it further

@sxyazi
Copy link
Owner

sxyazi commented Sep 29, 2024

Please try #1704

@TobisLee
Copy link
Contributor Author

Yeah, it works. Thanks.

Copy link

I'm going to lock this issue because it has been closed for 30 days. ⏳
This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please file a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants