Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed Execution on BTC is considered resolved if retried from EVM side #325

Closed
LyonSsS opened this issue Jul 3, 2024 · 3 comments
Closed

Comments

@LyonSsS
Copy link

LyonSsS commented Jul 3, 2024

Context: If an Execution fails on destination side ( BTC) by any reasons, we can execute RETRY from EVM side ( old behavior).
On this one, the Relayer considers this as an already resolved transaction.

Deposit: https://sepolia.etherscan.io/tx/0x39c9c4ec59d8b8aa416034c179e0d549b625a651980b65eea57712034684e052
Retry: https://sepolia.etherscan.io/tx/0x6fcb0dc29febe164013604bd1918e643ec41f14bdab5f037e11ebdc8ecad8182

Relayer log initial deposit execution here
image

Retry logs here
image

@mpetrun5
Copy link
Collaborator

mpetrun5 commented Jul 3, 2024

There is a PR for this based on audit issues: #319
Though there are some caveats to it described in the audit issue comments.

@LyonSsS
Copy link
Author

LyonSsS commented Jul 3, 2024

Going to keep this as cloned issue after #319 to remind to retest this.
Thanks for pointing it out @mpetrun5

@MakMuftic MakMuftic added this to the Cycle 5 🏆 milestone Jul 14, 2024
@LyonSsS LyonSsS closed this as completed Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants