CMS 5 compatibility using file string streams #23

michalkleiner · 2024-04-09T01:36:17Z

Building on top of or replacing existing PRs to provide compatibility with Silverstripe CMS 5 while using file string streams working with external file systems for assets storage such as AWS S3.

ground work done by @satrun77 in Add support for CMS 5 #21 👏
incorporates BUG Hide ClamAVScan from used on table #18 to hide the scans from the 'Used on' table
replaces inlined 3rd-party lib with a composer module xenolope/quahog that also works with newer versions of ClamAV
took inspiration from feat: allow use of streams to send files to clamd #19 to use file string streams (not file streams)
drops support for https://github.com/symbiote/silverstripe-cdncontent

Tested locally using fwust/ddev-clamav using a socket shared between containers as well as on Silverstripe Cloud with CMS 5.2-rc1 and PHP 8.3.

Fixes #22.

…lock The exists check returns false for newly updated files that need to be scanned using the validate method before they are written for the first time and considered existing.

…hat is expected in the try/catch blocks calling the function.

gurucomkz · 2024-11-05T09:34:41Z

This is awesome @michalkleiner !
I hope this gets approved soon enough.

I've encountered a problem when there's no clamd running (PHP8.1):

socket_connect(): unable to connect [2]: No such file or directory in /project/vendor/clue/socket-raw/src/Socket.php at line 111

#0 [internal function]: Symbiote\QueuedJobs\Services\JobErrorHandler->handleError()
#1 /project/vendor/clue/socket-raw/src/Socket.php(111): socket_connect()
#2 /project/vendor/clue/socket-raw/src/Factory.php(27): Socket\Raw\Socket->connect()
#3 /project/vendor/symbiote/silverstripe-steamedclams/src/ClamAV.php(151): Socket\Raw\Factory->createClient()
#4 /project/vendor/symbiote/silverstripe-steamedclams/src/ClamAV.php(102): Symbiote\SteamedClams\ClamAV->getClamd()
#5 /project/vendor/symbiote/silverstripe-steamedclams/src/ClamAV.php(85): Symbiote\SteamedClams\ClamAV->scanFileForVirus()

It can be suppressed by adding another catch to the protected function getClamd():

catch (\Exception $e) {
    throw new Exception('ClamAV error: ' . $e->getMessage());
}

Please, consider adding it. Thank you.

michalkleiner · 2024-11-05T11:36:53Z

Thanks for the comment @gurucomkz, will add the catch and fail more gracefully when the daemon is not available. On the merging side of things I can't do much, but can try and ping someone from Symbiote later on.

satrun77 and others added 7 commits January 23, 2024 13:57

Add support for CMS 5

c9cd36f

feat: allow use of streams to send files to clamd

fd12f07

BUG Hide ClamAVScan from used on table

442868a

Replace included thirdparty file with a newer composer dependency

5fd2653

Refactor to use string streams provided by assets adapter/flysystem

f07c619

Remove file exists check as all errors would be caught in the catch b…

41fd173

…lock The exists check returns false for newly updated files that need to be scanned using the validate method before they are written for the first time and considered existing.

Updating the type of Exception thrown by catch in getClamd to match w…

980afde

…hat is expected in the try/catch blocks calling the function.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CMS 5 compatibility using file string streams #23

CMS 5 compatibility using file string streams #23

michalkleiner commented Apr 9, 2024 •

edited

Loading

gurucomkz commented Nov 5, 2024

michalkleiner commented Nov 5, 2024

CMS 5 compatibility using file string streams #23

Are you sure you want to change the base?

CMS 5 compatibility using file string streams #23

Conversation

michalkleiner commented Apr 9, 2024 • edited Loading

gurucomkz commented Nov 5, 2024

michalkleiner commented Nov 5, 2024

michalkleiner commented Apr 9, 2024 •

edited

Loading