Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BadRequestException: Invalid URI #287

Open
ps-hidden opened this issue Jan 28, 2025 · 1 comment
Open

BadRequestException: Invalid URI #287

ps-hidden opened this issue Jan 28, 2025 · 1 comment

Comments

@ps-hidden
Copy link

ps-hidden commented Jan 28, 2025

Symfony added request uri validation and exception throwing in case of prohibited characters. Would like to see adequate handling of this exception or throw a more understandable exception

ref: symfony/http-foundation@168b77c#diff-de5d8eb3f1d6537c947f70e0a4673779312a902c083739f472c709c037bcbc30R366-R379

Symfony\Component\HttpFoundation\Request::create("http://foo.com\\bar");

@dbu
Copy link
Member

dbu commented Feb 9, 2025

sounds right to play nicely with that. which places lead to non-understandable exceptions?

i would assume at least some of the changes will go to the symfony cmf RoutingBundle, as the model and entity/document classes live there. though we have to be careful about BC, and about how the model might be created in several steps, or a workflow might even be constructed to start with an invalid model...

glad to review a pull request if you have any suggestions where we need to adjust the cmf repository for better error reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants