[Chat] Add streaming support & persistence to storage through accumulator callback chaining #928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marco-jouwweb
requested review from
Nyholm,
OskarStark and
chr-hertel
as code owners
carsonbot
changed the title
chr-hertel
reviewed
Nov 21, 2025
OskarStark
changed the title
carsonbot
changed the title
OskarStark
changed the title
OskarStark
reviewed
Nov 24, 2025
OskarStark
reviewed
Nov 24, 2025
OskarStark
reviewed
Nov 24, 2025
marco-jouwweb
force-pushed
the
feature/stream-support-chat-storage
branch
3 times, most recently
from
a1f4c83 to
8a71916
Compare
Guikingone
reviewed
Nov 28, 2025
marco-jouwweb
force-pushed
the
feature/stream-support-chat-storage
branch
from
7d97953 to
5b388c1
Compare
marco-jouwweb
force-pushed
the
feature/stream-support-chat-storage
branch
from
ab56dc7 to
301e15c
Compare
marco-jouwweb
force-pushed
the
feature/stream-support-chat-storage
branch
from
301e15c to
377d7d6
Compare
added 4 commits
December 1, 2025 09:38
added 11 commits
December 1, 2025 09:38
marco-jouwweb
force-pushed
the
feature/stream-support-chat-storage
branch
from
377d7d6 to
62503c1
Compare
Author
|
Had some trouble with Git as I never worked with a forked repo like this before, hence the force pushes.. However, the branch history should now be fixed, up-to-date & mergeable. |
Guikingone
reviewed
Dec 1, 2025
|
|
||
| return new AccumulatingStreamResult($result, function (AssistantMessage $assistantMessage) use ($messages) { | ||
| $messages->add($assistantMessage); | ||
| $this->store->save($messages); |
Contributor
There was a problem hiding this comment.
Could be done in a single line with $this->store->save($messages->with($assistantMessage));
This way, we could use an arrow function.
| if ($result instanceof StreamResult || $result instanceof ToolboxStreamResult) { | ||
| if (!$this->store instanceof StreamableStoreInterface) { | ||
| throw new RuntimeException($this->store::class.' does not support streaming.'); | ||
| } |
Contributor
There was a problem hiding this comment.
I'm not sure that we should throw an exception here, maybe just returning the complete stream at once?
Or maybe we can just store the message "as it" in the store?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
Chat::submit()function didn't support streaming. I have added support for this through:AccumulatingStreamResultwrapper which allows callback chaining and accumulates the full message (callbacks are fired onceGeneratorin innerStreamResultis exhausted, aka when stream has completed)StreamResultclasses with this wrapper inside theChat::submit()functionStoragewith a newAssistantMessagebuilt from the accumulated message (as non-stream responses are also automatically added to storage inChat::submit())Other changes:
StreamableStoreInterfacewhich indicates aStoreimplementation supports streaming. Currently added to all stores exceptSessionStorage(due to inherent issues with headers being already sent; deferred updates through callbacks go against nature of header/session lifecycles in Symfony; discussed with @Guikingone)Chat::submit()(metadata was not transferred to newAssistantMessagewe created)Chat::submit()combination