Merge branch '4.4' into 5.0

fabpot · fabpot · commit 4368bdd61b83 · 2020-02-29T11:07:09.000+01:00
* 4.4:
  [Dotenv] Documentation improvement
  [DI] Clarified deprecation for TypedReference in 4.4
  [Validator] Add missing vietnamese translations
  add German translation
  add missing Messenger options to XML schema definition
  [Validator][ConstraintValidator] Update wrong PRETTY_DATE doc
  [DomCrawler][Form] Fix PHPDoc on get &amp; offsetGet
  [ErrorHandler] fix parsing static return type on interface method annotation (fix #35836)
  prevent method calls on null values
  Return int if scale = 0
diff --git a/Form.php b/Form.php
@@ -273,7 +273,7 @@ public function remove(string $name)
     /**
      * Gets a named field.
      *
-     * @return FormField The field instance
+     * @return FormField|FormField[]|FormField[][] The value of the field
      *
      * @throws \InvalidArgumentException When field is not present in this form
      */
@@ -317,7 +317,7 @@ public function offsetExists($name)
      *
      * @param string $name The field name
      *
-     * @return FormField The associated Field instance
+     * @return FormField|FormField[]|FormField[][] The value of the field
      *
      * @throws \InvalidArgumentException if the field does not exist
      */
diff --git a/FormFieldRegistry.php b/FormFieldRegistry.php
@@ -66,7 +66,7 @@ public function remove(string $name)
     /**
      * Returns the value of the field based on the fully qualifed name and its children.
      *
-     * @return mixed The value of the field
+     * @return FormField|FormField[]|FormField[][] The value of the field
      *
      * @throws \InvalidArgumentException if the field does not exist
      */
diff --git a/Tests/FormTest.php b/Tests/FormTest.php
@@ -12,6 +12,7 @@
 namespace Symfony\Component\DomCrawler\Tests;
 
 use PHPUnit\Framework\TestCase;
+use Symfony\Component\DomCrawler\Field\TextareaFormField;
 use Symfony\Component\DomCrawler\Form;
 use Symfony\Component\DomCrawler\FormFieldRegistry;
 
@@ -965,7 +966,7 @@ protected function createTestMultipleForm()
         return $dom;
     }
 
-    public function testgetPhpValuesWithEmptyTextarea()
+    public function testGetPhpValuesWithEmptyTextarea()
     {
         $dom = new \DOMDocument();
         $dom->loadHTML('
@@ -980,4 +981,34 @@ public function testgetPhpValuesWithEmptyTextarea()
         $form = new Form($nodes->item(0), 'http://example.com');
         $this->assertEquals($form->getPhpValues(), ['example' => '']);
     }
+
+    public function testGetReturnTypes()
+    {
+        $dom = new \DOMDocument();
+        $dom->loadHTML('
+            <html>
+                <form>
+                    <textarea name="foo[collection][0][bar]">item 0</textarea>
+                </form>
+            </html>'
+        );
+
+        $nodes = $dom->getElementsByTagName('form');
+        $form = new Form($nodes->item(0), 'http://example.com');
+
+        // FormField
+        $this->assertInstanceOf(TextareaFormField::class, $textareaFormField = $form->get('foo[collection][0][bar]'));
+
+        // Array of FormField
+        $this->assertSame([
+            'bar' => $textareaFormField,
+        ], $form->get('foo[collection][0]'));
+
+        // Array of array of FormField
+        $this->assertSame([
+            [
+                'bar' => $textareaFormField,
+            ],
+        ], $form->get('foo[collection]'));
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -273,7 +273,7 @@ public function remove(string $name)`
`273`	`273`	`/**`
`274`	`274`	`* Gets a named field.`
`275`	`275`	`*`
`276`		`- * @return FormField The field instance`
	`276`	`+ * @return FormField\|FormField[]\|FormField[][] The value of the field`
`277`	`277`	`*`
`278`	`278`	`* @throws \InvalidArgumentException When field is not present in this form`
`279`	`279`	`*/`
`@@ -317,7 +317,7 @@ public function offsetExists($name)`
`317`	`317`	`*`
`318`	`318`	`* @param string $name The field name`
`319`	`319`	`*`
`320`		`- * @return FormField The associated Field instance`
	`320`	`+ * @return FormField\|FormField[]\|FormField[][] The value of the field`
`321`	`321`	`*`
`322`	`322`	`* @throws \InvalidArgumentException if the field does not exist`
`323`	`323`	`*/`
Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ public function remove(string $name)`
`66`	`66`	`/**`
`67`	`67`	`* Returns the value of the field based on the fully qualifed name and its children.`
`68`	`68`	`*`
`69`		`- * @return mixed The value of the field`
	`69`	`+ * @return FormField\|FormField[]\|FormField[][] The value of the field`
`70`	`70`	`*`
`71`	`71`	`* @throws \InvalidArgumentException if the field does not exist`
`72`	`72`	`*/`