Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added alms/cycle-bundle #1569

Merged
merged 7 commits into from
Jan 20, 2024
Merged

Conversation

AlessandroAmos
Copy link
Contributor

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) November 24, 2023 22:32
Copy link

github-actions bot commented Nov 24, 2023

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1569/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1569/index.json
  2. Install the package(s) related to this recipe:

    composer req 'symfony/flex:^1.16'
    composer req 'alms/cycle-bundle:^0.1'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

auto-merge was automatically disabled November 24, 2023 22:44

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) November 24, 2023 22:44
auto-merge was automatically disabled November 24, 2023 22:46

Head branch was pushed to by a user without write access

… 2 levels instead of 4.

Added the migrations folder that I forgot.
@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) November 24, 2023 22:46
auto-merge was automatically disabled November 24, 2023 22:48

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) November 24, 2023 22:48
@AlessandroAmos
Copy link
Contributor Author

It seems that your package may not pass the second test because it runs only on PHP 8. It's a fork that you plan to maintain, integrating another ORM similar to Doctrine called Cycle ORM. The issue is that the cycle/orm package has PHP 8 as its limit.

auto-merge was automatically disabled November 29, 2023 13:57

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) November 29, 2023 13:58
auto-merge was automatically disabled November 29, 2023 15:32

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) November 29, 2023 15:33
@symfony-recipes-bot symfony-recipes-bot merged commit 07cc241 into symfony:main Jan 20, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants