Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backwards compatibility with 2.2.5? #19

Open
davidhund opened this issue Mar 12, 2012 · 5 comments
Open

backwards compatibility with 2.2.5? #19

davidhund opened this issue Mar 12, 2012 · 5 comments

Comments

@davidhund
Copy link

Hi Remie,

(Without thinking) I just pulled my /extensions/gettext submodule to fetch all your recent fixes etc.

However, I am running Symphony 2.2.5 and my site now throws an error:

Fatal error: Class extension_gettext contains 1 abstract method and must therefore be declared abstract or implement the 
remaining methods (Extension::about) in /my/site/extensions/gettext/extension.driver.php on line 118

You are only using the (newer) meta.xml stuff and not the (default) about(). I believe this makes my site trip up.

Is it possible to use your latest version with 2.2.5 if I'd add the about() method or are there other compatibility issues with 2.2.5?

@remie
Copy link
Collaborator

remie commented Mar 12, 2012

I think adding the about() methode should do the trick, haven't tried it
though.
But I've read the 2.3 Migration document for extension developers and I
haven't used any of the new features nor did I have to make any changes
because of deprecated methods.

Cheers,

Remie

On Mon, Mar 12, 2012 at 12:15 PM, David Hund <
reply@reply.github.com

wrote:

Hi Remie,

(Without thinking) I just pulled my /extensions/gettext submodule to
fetch all your recent fixes etc.

However, I am running Symphony 2.2.5 and my site now throws an error:

Fatal error: Class extension_gettext contains 1 abstract method and
must therefore be declared abstract or implement the
remaining methods (Extension::about) in
/my/site/extensions/gettext/extension.driver.php on line 118

You are only using the (newer) meta.xml stuff and not the (default)
about(). I believe this makes my site trip up.

Is it possible to use your latest version with 2.2.5 if I'd add the
about() method or are there other compatibility issues with 2.2.5?


Reply to this email directly or view it on GitHub:
#19

@remie
Copy link
Collaborator

remie commented Mar 12, 2012

BTW: you should be able to revert to version 2.0.1 of gettext by switching
to the Tag.

On Mon, Mar 12, 2012 at 3:19 PM, Remie Bolte r.bolte@gmail.com wrote:

I think adding the about() methode should do the trick, haven't tried it
though.
But I've read the 2.3 Migration document for extension developers and I
haven't used any of the new features nor did I have to make any changes
because of deprecated methods.

Cheers,

Remie

On Mon, Mar 12, 2012 at 12:15 PM, David Hund <
reply@reply.github.com

wrote:

Hi Remie,

(Without thinking) I just pulled my /extensions/gettext submodule to
fetch all your recent fixes etc.

However, I am running Symphony 2.2.5 and my site now throws an error:

Fatal error: Class extension_gettext contains 1 abstract method and
must therefore be declared abstract or implement the
remaining methods (Extension::about) in
/my/site/extensions/gettext/extension.driver.php on line 118

You are only using the (newer) meta.xml stuff and not the (default)
about(). I believe this makes my site trip up.

Is it possible to use your latest version with 2.2.5 if I'd add the
about() method or are there other compatibility issues with 2.2.5?


Reply to this email directly or view it on GitHub:
#19

@davidhund
Copy link
Author

Thanks. I just did a git reset --hard SHA to 'go back'. Bummer but I can't yet update to 2.3 :)

@remie
Copy link
Collaborator

remie commented Mar 12, 2012

If you really need the fixes I can check if I can squeeze in a 2.0.2
release which is backwards compatible.

On Mon, Mar 12, 2012 at 4:03 PM, David Hund <
reply@reply.github.com

wrote:

Thanks. I just did a git reset --hard SHA to 'go back'. Bummer but I
can't yet update to 2.3 :)


Reply to this email directly or view it on GitHub:
#19 (comment)

@davidhund
Copy link
Author

That would be very nice, but if all that is needed for 2.2.5 compat. is to add the about() method I'm more than happy to just do that myself locally. If there are more issues re: compatibility I probably need some pointers but you don't need to spend much more time on this only for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants