Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SY-1217 schematic edges incorrectly positioned #829

Merged
merged 7 commits into from
Sep 16, 2024

Conversation

emilbon99
Copy link
Contributor

Fix Pull Request Template

Key Information

Description

Maximum 2-3 sentence description describing the changes.

Basic Readiness Checklist

  • I have performed a self-review of my code.
  • I have added sufficient regression tests to cover the changes to CI.
  • I have added relevant tests to cover the changes or exposing bugs.
  • I have verified code coverage targets are met.

Additional Notes

  • These changes deal with concurrency.
  • These changes affect UI.

Manual QA Additions

  • I have updated the Release Candidate template
    with necessary manual QA steps to test my change.

Reviewer Checklist

  • Sufficient test coverage of new additions.
  • Verified all steps in readiness checklists.
  • UI changes have been tested.
  • style and formatting is consistent.
  • Reviewed any relevant changes to concurrent code for safety.
  • Sufficient comments and clarity of code.

@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 46.33%. Comparing base (45a3fe8) to head (cd8b0d7).
Report is 1 commits behind head on rc.

Files with missing lines Patch % Lines
pluto/src/vis/diagram/edge/connector/connector.ts 0.00% 3 Missing ⚠️
pluto/src/vis/diagram/aether/types.ts 0.00% 1 Missing ⚠️
pluto/src/vis/diagram/util.ts 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##               rc     #829      +/-   ##
==========================================
- Coverage   46.33%   46.33%   -0.01%     
==========================================
  Files        1088     1088              
  Lines       67883    67885       +2     
  Branches     3512     3512              
==========================================
  Hits        31455    31455              
- Misses      35377    35378       +1     
- Partials     1051     1052       +1     
Flag Coverage Δ
pluto 35.34% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lham42 Lham42 changed the title Sy 1217 schematic edges incorrectly positionined SY-1217 schematic edges incorrectly positionined Sep 16, 2024
@Lham42
Copy link
Contributor

Lham42 commented Sep 16, 2024

Add pr description

@Lham42
Copy link
Contributor

Lham42 commented Sep 16, 2024

Add Pr description

@Lham42 Lham42 added the console label Sep 16, 2024
console/src/schematic/Schematic.tsx Outdated Show resolved Hide resolved
console/src-tauri/gen/schemas/windows-schema.json Outdated Show resolved Hide resolved
@Lham42 Lham42 changed the title SY-1217 schematic edges incorrectly positionined SY-1217 schematic edges incorrectly positioned Sep 16, 2024
Copy link
Contributor

@Lham42 Lham42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@pjdotson pjdotson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved after addressing comments.

console/src/schematic/Schematic.tsx Outdated Show resolved Hide resolved
console/src-tauri/gen/schemas/windows-schema.json Outdated Show resolved Hide resolved
pluto/src/vis/schematic/primitives/Primitives.tsx Outdated Show resolved Hide resolved
@emilbon99 emilbon99 merged commit 3c6a44d into rc Sep 16, 2024
33 checks passed
@emilbon99 emilbon99 deleted the sy-1217-schematic-edges-incorrectly-positionined branch September 16, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants