Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move services into service directory #833

Closed
wants to merge 5 commits into from

Conversation

Lham42
Copy link
Contributor

@Lham42 Lham42 commented Sep 19, 2024

Fix Pull Request Template

Key Information

Description

Moves service layer directories into service directory for clarity

Basic Readiness Checklist

  • I have performed a self-review of my code.
  • I have added sufficient regression tests to cover the changes to CI.
  • I have added relevant tests to cover the changes or exposing bugs.
  • I have verified code coverage targets are met.

Additional Notes

  • These changes deal with concurrency.
  • These changes affect UI.

Manual QA Additions

  • I have updated the Release Candidate template
    with necessary manual QA steps to test my change.

Reviewer Checklist

  • Sufficient test coverage of new additions.
  • Verified all steps in readiness checklists.
  • UI changes have been tested.
  • style and formatting is consistent.
  • Reviewed any relevant changes to concurrent code for safety.
  • Sufficient comments and clarity of code.

@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 46.34%. Comparing base (3c6a44d) to head (c926228).
Report is 3 commits behind head on rc.

Files with missing lines Patch % Lines
synnax/pkg/api/mock/mock.go 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##               rc     #833      +/-   ##
==========================================
- Coverage   46.34%   46.34%   -0.01%     
==========================================
  Files        1088     1088              
  Lines       67885    67885              
  Branches     3512     3512              
==========================================
- Hits        31462    31461       -1     
- Misses      35372    35373       +1     
  Partials     1051     1051              
Flag Coverage Δ
clientpy 86.04% <ø> (ø)
clientts 61.35% <ø> (ø)
synnax 28.59% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants