Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sy 1245 fix race condition in auto controller #837

Merged
merged 10 commits into from
Sep 26, 2024
Merged

Sy 1245 fix race condition in auto controller #837

merged 10 commits into from
Sep 26, 2024

Conversation

emilbon99
Copy link
Contributor

@emilbon99 emilbon99 commented Sep 26, 2024 •
edited by Lham42
Loading

Fix Pull Request Template

Key Information

Description

Fixes 2 issues:

  1. Race condition that causes an error with Receiver.processors in which updating the processors throws an exception due to concurrent set iteration.
  2. Adds an acknowledgement step to opening a streamer that ensures a streamer has been fully initialized before the called can proceed with reading values.

** This change will break compatibility when using this version of the client with older versions of the server.**

Basic Readiness Checklist

  • I have performed a self-review of my code.
  • I have added sufficient regression tests to cover the changes to CI.
  • I have added relevant tests to cover the changes or exposing bugs.
  • I have verified code coverage targets are met.

Additional Notes

  • These changes deal with concurrency.
  • These changes affect UI.

Manual QA Additions

  • I have updated the Release Candidate template
    with necessary manual QA steps to test my change.

Reviewer Checklist

  • Sufficient test coverage of new additions.
  • Verified all steps in readiness checklists.
  • UI changes have been tested.
  • style and formatting is consistent.
  • Reviewed any relevant changes to concurrent code for safety.
  • Sufficient comments and clarity of code.

@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 78.94737% with 4 lines in your changes missing coverage. Please review.

Project coverage is 46.33%. Comparing base (37e0fd9) to head (d7e5039).

Files with missing lines Patch % Lines
synnax/pkg/api/framer.go 0.00% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #837      +/-   ##
==========================================
+ Coverage   46.32%   46.33%   +0.01%     
==========================================
  Files        1088     1088              
  Lines       67885    67895      +10     
  Branches     3512     3513       +1     
==========================================
+ Hits        31447    31460      +13     
+ Misses      35386    35382       -4     
- Partials     1052     1053       +1
Flag Coverage Δ
aspen 50.23% <ø> (-0.18%) ⬇️
cesium 75.53% <ø> (ø)
clientpy 86.04% <ø> (ø)
clientts 61.36% <100.00%> (+0.01%) ⬆️
drift 26.30% <ø> (ø)
freighterpy 81.03% <ø> (ø)
freighterts 83.25% <ø> (ø)
pluto 35.34% <ø> (ø)
synnax 28.58% <76.47%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Lham42
Lham42 requested changes Sep 26, 2024
View reviewed changes
client/cpp/framer/streamer.cpp Show resolved Hide resolved
synnax/pkg/distribution/framer/relay/streamer.go Outdated Show resolved Hide resolved
@Lham42 Lham42 merged commit 890b5c6 into main Sep 26, 2024
31 of 32 checks passed
@pjdotson pjdotson deleted the sy-1245-fix-race-condition-in-auto-controller branch October 3, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lham42 Lham42 Lham42 approved these changes

Assignees
No one assigned
Labels
hotfix merge into main
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emilbon99 @codecov-commenter @Lham42