Skip to content

Commit 4b1ec63

Browse files
authored
Merge pull request #100 from truh/cleanup-unused-loops
Cleanup unused loops
2 parents f4a90ed + 9c3d730 commit 4b1ec63

File tree

4 files changed

+5
-6
lines changed

4 files changed

+5
-6
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,3 +13,4 @@ __pycache__/
1313
venv/
1414
Pipfile.lock
1515
.envrc
16+
.pdm-python

.pdm-python

Lines changed: 0 additions & 1 deletion
This file was deleted.

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -115,13 +115,13 @@ that does not rely on async generators but instead uses memory channels (`exampl
115115

116116
## Development, Contributing
117117
1. install pdm: `pip install pdm`
118-
2. install dependencies using pipenv: `pdm install -d.`
118+
2. install dependencies using pipenv: `pdm install -d`.
119119
3. To run tests:
120120

121121
### Makefile
122122
- make sure your virtualenv is active
123123
- check `Makefile` for available commands and development support, e.g. run the unit tests:
124-
```python
124+
```shell
125125
make test
126126
make tox
127127
```

tests/integration/test_multiple_consumers.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -155,10 +155,9 @@ def test_stop_server_with_many_consumers(caplog, server_command, expected_lines)
155155
if server_process is None or server_process.poll() is not None:
156156
pytest.fail("Server did not start.")
157157

158-
# Initialize asyncio loops and threads
159-
loops = [asyncio.new_event_loop() for _ in range(N_CONSUMER)]
158+
# Initialize threads
160159
threads = []
161-
for loop in loops:
160+
for _ in range(N_CONSUMER):
162161
thread = threading.Thread(
163162
target=lambda: asyncio.run(
164163
make_arequest(f"{URL}:{port}/endless", expected_lines=expected_lines)

0 commit comments

Comments
 (0)