Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebrand #1

Open
jserv opened this issue Jul 17, 2024 · 0 comments
Open

Rebrand #1

jserv opened this issue Jul 17, 2024 · 0 comments
Assignees
@jserv

Comments

@jserv
Copy link
Contributor

jserv commented Jul 17, 2024

Mado is a continuation of the work on TWIN, originally developed by Keith Packard, and all occurrences of TWIN still exist in this project. It would be better to rebrand explicitly when we achieve some distinguished milestones, such as implementing the Linux framebuffer/DRM backend and image loaders.
@jserv jserv self-assigned this Jul 17, 2024
jserv added a commit that referenced this issue Sep 12, 2024
@jserv
Fix out-of-bounds read access in GIF decoding
aeb0ad3 
Caught by lldb:

* thread #1, stop reason = EXC_BAD_ACCESS (code=1, address=0x1080d6000)
    frame #0: 0x00000001000061a4 demo-sdl`_twin_gif_to_pixmap [inlined] gif_is_bgcolor(gif=0x00000001008b4200, color=<unavailable>) at image-gif.c:516:13 [opt]
   513
   514 	static int gif_is_bgcolor(const twin_gif_t *gif, const uint8_t *color)
   515 	{
-> 516 	    return !memcmp(&gif->palette->colors[gif->bgindex * 3], color, 3);
   517 	}
   518
   519 	static void gif_rewind(twin_gif_t *gif)
Target 0: (demo-sdl) stopped.
(lldb) up
frame #1: 0x000000010000619e demo-sdl`_twin_gif_to_pixmap at image-gif.c:584 [opt]
   581 	            uint8_t r = *(color++);
   582 	            uint8_t g = *(color++);
   583 	            uint8_t b = *(color++);
-> 584 	            if (!gif_is_bgcolor(gif, color))
   585 	                *(p.argb32++) = 0xFF000000U | (r << 16) | (g << 8) | b;
   586 	            /* Construct background */
   587 	            else if (((row >> 3) + (col >> 3)) & 1)

The removal of unnecessary pointer arithmetics also help compiler
optimizations.
@jserv jserv mentioned this issue Sep 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jserv jserv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jserv