-
Notifications
You must be signed in to change notification settings - Fork 0
/
ChangeLog
20744 lines (14123 loc) · 879 KB
/
ChangeLog
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
This ChangeLog is automatically generated from the git commit messages
during the snapshot process. See README.snapshots and utils/git2cl.
2014-03-16 DJ Delorie * dj AT delorie dot com *
* tests/golden/hid_gcode4/gcode_oneline-bottom.gcode,
tests/golden/hid_gcode4/gcode_oneline-top.gcode,
tests/golden/hid_gcode6/gcode_oneline-bottom.gcode,
tests/golden/hid_gcode6/gcode_oneline-top.gcode: update gcode golden
files Checked with linuxcnc - the old goldens had zeros where the
parameters should have been.
2014-02-23 Jorge Barros de Abreu * ficmatin10 AT gmail dot com *
* po/pt_BR.po: pt_BR adjusts and make update-po Signed-off-by: bert * bert dot timmerman AT xs4all dot nl *
2014-02-03 Jorge Barros de Abreu * ficmatin10 AT gmail dot com *
* po/pt_BR.po: pt_BR.po update Closes-bug: lp-1275446
2014-02-03 Jorge Barros de Abreu * ficmatin10 AT gmail dot com *
* po/pt_BR.po: Minor changes in po pt_BR.po file Closes-bug: lp-1274404
2014-02-03 Vladimir Zhbanov * vzhbanov AT gmail dot com *
* src/hid/gtk/gui-config.c: Fix segfault caused by lack of commas in
a format expression Closes-bug: lp-1275407
2014-02-01 Jorge Barros de Abreu * ficmatin10 AT gmail dot com *
* po/pt_BR.po: Preferencias do PCB to Preferências... Signed-off-by: bert * bert dot timmerman AT xs4all dot nl *
2014-02-01 Vladimir Zhbanov * vzhbanov AT gmail dot com *
* doc/pcb.texi: Fix order of sections in the documentation Prevent warnings output by "make" when pcb.texi is processed.
2014-01-31 Vladimir Zhbanov * vzhbanov AT gmail dot com *
* doc/pcb.texi: Fix several typos in the documentation
2014-01-31 أحمد المحمودي (Ahmed El-Mahmoudy) * aelmahmoudy AT sabily dot org *
* src/pcbtest.sh.in: Fix 'make distcheck' Use proper target directory for pcblib-newlib. Closes-bug: lp-855405 Commit-message-by: Vladimir Zhbanov * vzhbanov AT gmail dot com *
2014-01-31 Vladimir Zhbanov * vzhbanov AT gmail dot com *
* po/POTFILES.in, po/POTFILES.skip: Add one more localized file to
POTFILES.in Additionally, the file generated from it is moved to POTFILES.skip
2013-01-30 Sergey Alyoshin * alyoshin dot s AT gmail dot com *
* src/action.c, src/buffer.c, src/hid/common/actions.c,
src/hid/gtk/gtkhid-main.c, src/hid/gtk/gui-config.c,
src/hid/gtk/gui-dialog.c, src/hid/gtk/gui-drc-window.c,
src/hid/gtk/gui-output-events.c, src/hid/gtk/gui-top-window.c,
src/hid/lpr/lpr.c, src/misc.c, src/parse_y.y, src/report.c,
src/toporouter.c, src/vendor.c: Add strings to localization Signed-off-by: Bert Timmerman * bert dot timmerman AT xs4all dot nl
* Signed-off-by: bert * bert dot timmerman AT xs4all dot nl *
2014-01-30 Vladimir Zhbanov * vzhbanov AT gmail dot com *
* src/hid/bom/bom.c: Don't use localized unit names in comments of
the X-Y files Fix a bug causing 'make distcheck' to fail for all bom_hid# tests in
localized environments because of using of a localized unit name in
a comment line of the output X-Y file.
2014-01-29 Vladimir Zhbanov * vzhbanov AT gmail dot com *
* po/POTFILES.in: Add a missing file to POTFILES.in
2014-01-29 Vladimir Zhbanov * vzhbanov AT gmail dot com *
* data/Makefile.am: Remove a duplicated line INTLTOOL_XML_RULE is used twice in Makefile.am, which results in
having two same lines in generated Makefile.
2014-01-29 Vladimir Zhbanov * vzhbanov AT gmail dot com *
* data/Makefile.am: Fix 'make distcheck' 'make distcheck' has been broken again in
c74ba603517380bae59f1ff68a5f100c2fb1c960
2014-01-29 Vladimir Zhbanov * vzhbanov AT gmail dot com *
* src/Makefile.am: Fix 'make distcheck' Fix a bug introduced in 6aa50cc4c93fec243cba9cd37c86090496af3feb
2012-12-04 Sergey Alyoshin * alyoshin dot s AT gmail dot com *
* src/hid/gtk/gui-utils.c: Allow hotkeys in button labels Use _with_mnemonic functions to allow '_' hotkey. Signed-off-by: bert * bert dot timmerman AT xs4all dot nl *
2012-12-02 Sergey Alyoshin * alyoshin dot s AT gmail dot com *
* src/hid/gtk/gui-output-events.c, src/macro.h: Add UNKNOWN_NAME
macro UNKNOWN_NAME macro is the same as UNKNOWN, but allow to specify
"unknown name", which can be useful for localization. Signed-off-by: bert * bert dot timmerman AT xs4all dot nl *
2014-01-26 Sergey Alyoshin * alyoshin dot s AT gmail dot com *
* src/hid/gtk/gui-top-window.c: Add tooltips to mode menu buttons Signed-off-by: bert * bert dot timmerman AT xs4all dot nl *
2014-01-18 Sergey Alyoshin * alyoshin dot s AT gmail dot com *
* po/POTFILES.in, src/hid/lpr/lpr.c, src/hid/ps/ps.c: Add strings
from LPR and PS HID's to translation Signed-off-by: bert * bert dot timmerman AT xs4all dot nl *
2012-12-02 Sergey Alyoshin * alyoshin dot s AT gmail dot com *
* src/hid/gtk/gui-dialog-print.c: Print dialog i18n Signed-off-by: bert * bert dot timmerman AT xs4all dot nl *
2014-01-26 bert * bert dot timmerman AT xs4all dot nl *
* data/.gitignore: Ignore data/pcb.appdata.xml. Signed-off-by: bert * bert dot timmerman AT xs4all dot nl *
2014-01-25 bert * bert dot timmerman AT xs4all dot nl *
* data/Makefile.am, data/pcb.appdata.xml, data/pcb.appdata.xml.in,
po/POTFILES.in: Let appdata have translatable strings. Signed-off-by: bert * bert dot timmerman AT xs4all dot nl *
2014-01-12 bert * bert dot timmerman AT xs4all dot nl *
* data/Makefile.am: Added the appdata target to the Makefile. Signed-off-by: bert * bert dot timmerman AT xs4all dot nl *
2014-01-12 bert * bert dot timmerman AT xs4all dot nl *
* data/pcb.appdata.xml: Added an appdata file. Signed-off-by: bert * bert dot timmerman AT xs4all dot nl *
2013-02-03 Bert Timmerman * bert dot timmerman AT xs4all dot nl *
* src/hid/gtk/gui-netlist-window.c: Fixing a typo. Signed-off-by: Bert Timmerman * bert dot timmerman AT xs4all dot nl
* Signed-off-by: bert * bert dot timmerman AT xs4all dot nl *
2013-02-03 Sergey Alyoshin * alyoshin dot s AT gmail dot com *
* src/hid/gtk/gui-config.c, src/hid/gtk/gui-misc.c,
src/hid/gtk/gui-netlist-window.c, src/report.c: Add strings to
translation with context Signed-off-by: Bert Timmerman * bert dot timmerman AT xs4all dot nl
* Signed-off-by: bert * bert dot timmerman AT xs4all dot nl *
2012-12-01 Sergey Alyoshin * alyoshin dot s AT gmail dot com *
* src/gettext.h, src/global.h: Use gettext.h for pgettext() Signed-off-by: bert * bert dot timmerman AT xs4all dot nl *
2014-01-26 Sergey Alyoshin * alyoshin dot s AT gmail dot com *
* po/ru.po: Updated Russian translation Signed-off-by: bert * bert dot timmerman AT xs4all dot nl *
2014-01-25 Jorge Barros de Abreu * ficmatin10 AT gmail dot com *
* po/pt_BR.po: pt_BR language update Signed-off-by: bert * bert dot timmerman AT xs4all dot nl *
2013-09-02 Sergey Alyoshin * alyoshin dot s AT gmail dot com *
* src/find.c: Use ngettext for message with plural form Signed-off-by: bert * bert dot timmerman AT xs4all dot nl *
2014-01-16 xmd * shinobi dot jack AT gmail dot com *
* src/hid/gerber/gerber.c: gerber.c: added an option for Hackvana
file name convention. Signed-off-by: bert * bert dot timmerman AT xs4all dot nl *
2012-12-01 Sergey Alyoshin * alyoshin dot s AT gmail dot com *
* src/hid/gtk/ghid-main-menu.c: Menu items i18n This adds i18n for gtk menus Closes-bug: lp-1113758
2014-01-20 Vladimir Zhbanov * vzhbanov AT gmail dot com *
* autogen.sh, src/.gitignore, src/Makefile.am: Fix menu
gettextization Changes were made to eliminate errors output by 'make distcheck' or
'make -C po update-po'. Closes-bug: lp-913458
2012-12-01 Sergey Alyoshin * alyoshin dot s AT gmail dot com *
* po/POTFILES.in: Fix .res.in to .res.h in POTFILES.in Affects-bug: lp-913458
2014-01-18 Jorge Barros de Abreu * ficmatin10 AT gmail dot com *
* po/LINGUAS, po/pt_BR.po: Added pt_BR translation file. Signed-off-by: bert * bert dot timmerman AT xs4all dot nl *
2013-10-10 Kevin Redon * kevredon AT mail dot tsaitgaist dot info *
* src/djopt.c: add missing option splitlines in djopt_syntax Signed-off-by: bert * bert dot timmerman AT xs4all dot nl *
2013-10-10 Kevin Redon * kevredon AT mail dot tsaitgaist dot info *
* src/action.c: fix missing ) typo in changeclearsize_syntax Signed-off-by: bert * bert dot timmerman AT xs4all dot nl *
2013-10-27 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/hid/gtk/gui-misc.c, src/hid/gtk/gui-top-window.c: Fix lockup
when a scroll event is received outside the drawing area This can occur if the user is dragging a component in the drawing
area (hence a pointer grab is in operation), and during this drag,
the user moves the mouse outside the drawing area and touches the
scroll wheel. We then hit the scroll event handler, mouse action handler, action
dispatcher etc.. and find we do not have a current location known.
(The cursor is outside the drawing area). We then prompt for a
location, and using a recursive main- loop, wait for some kind (e.g.
a mouse click) which gives one. The problem appears to be caused by the fact it is likely we get a
second scroll event with the first, and that we process this from
within the recursive main-loop. We are still outside the drawing
area, so prompt the user for a location, and enter another level of
recursion. (In my tests, I was able to hit 6 or 7 levels deep of
main-loop recursion). Our code fails to exit its recursive main-loop if it rucurses, and
in any case, we would not want to prompt the user "n" times in a
row. The failure to exit from recursion is probably due to the event
handlers attached by the first recursive main-loop being called
prior to those attached later. (We attempt to quit the first
recursive main-loop, but cannot, as there are others now running). As a quick work-around to the immediate problem, prevent scroll
events being received from within the recursive main-loop. This
prevents the lockup, but ideally we should re-think how we handle
these events to avoid requiring the user to click on a coordinate. I have also added a GDK_THREADS_{LEAVE,ENTER} pair around running
the main-loop, as this is what GTK's code does for gtk_dialog_run().
2013-08-03 Markus Hitter * mah AT jump-ing dot de *
* tests/golden/hid_bom1/Makefile.am,
tests/golden/hid_bom1/bom_general.bom,
tests/golden/hid_bom1/bom_general.xy,
tests/golden/hid_bom2/Makefile.am,
tests/golden/hid_bom2/bom_general.xy,
tests/golden/hid_bom2/test.bom,
tests/golden/hid_bom3/bom_general.bom,
tests/golden/hid_bom3/test.xy,
tests/golden/hid_bom4/bom_general.bom,
tests/golden/hid_bom4/bom_general.xy: Regenerate tests after "Make
xy file output IPC 7531 compliant.".
2012-12-31 dark141 AT gmail dot com * dark141 AT gmail dot com *
* src/hid/bom/bom.c: Make xy file output IPC 7531 compliant. Improved code style by Bert Timmerman * bert dot timmerman AT
xs4all dot nl * dot
2013-08-02 Eugene Mikhantiev * mikhantiev AT gmail dot com *
* po/POTFILES.skip: Add intl/plural.c to POTFILES.skip
2012-11-08 Markus Hitter * mah AT jump-ing dot de *
* src/action.c: src/action.c: add a number of comments. ... in the hope they're right.
2013-07-31 Markus Hitter * mah AT jump-ing dot de *
* src/res_parse.y: src/res_parse.y: handle resource globals
gracefully. Likely, res_file is used somewhere to check something. In case a
resource file was loaded earlier, but the current parsing is from a
string, res_file is still != NULL, so this check would mislead. Solution: Clear res_file and res_filename as soon as the file behind it gets closed. Also replace a number of zeros with the more appropriate NULL. Affects-bug: lp-1206882
2013-07-15 DJ Delorie * dj AT delorie dot com *
* src/action.c: Additional checks for existing names In ActionElementList, add an additional check for
DESCRIPTION_NAME(e) before comparing with an old footprint.
2013-06-22 Bert Timmerman * bert dot timmerman AT xs4all dot nl *
* src/Makefile.am: src/Makefile.am: revert the AM_CPPFLAGS change as
it breaks the building process. Signed-off-by: Bert Timmerman * bert dot timmerman AT xs4all dot nl
*
2013-06-18 Leo Bärring * leo dot barring AT gmail dot com *
* configure.ac, doc/extract-docs, doc/pcb.texi, gts/Makefile.am,
src/Makefile.am, src/hid/lesstif/main.c: Patch to resolve archlinux
build warn/errors. Signed-off-by: Bert Timmerman * bert dot timmerman AT xs4all dot nl
*
2013-04-19 Gabriel Paubert * paubert AT iram dot es *
* src/hid/gerber/gerber.c: Gerber: use 0.1mil resolution for
imperial drill files. Acked-by: Andrew Poelstra * apoelstra AT wpsoftware dot net *
Acked-by: Peter Stuge * peter AT stuge dot se *
2013-04-19 Gabriel Paubert * paubert AT iram dot es *
* src/pcb-printf.c, src/pcb-printf.h: pcb-printf: Add 0.1mil
resolution, improve documentation and a small cleanup. 0.1mil resolution is needed for improved imperial drill file
generation. Apart form this, the list of %m unit modifiers is now
fully documented and a redundant test was removed. Acked-by: Andrew Poelstra * apoelstra AT wpsoftware dot net *
Acked-by: Peter Stuge * peter AT stuge dot se *
2013-04-19 Gabriel Paubert * paubert AT iram dot es *
* src/hid/gerber/gerber.c: Gerber: reset aperture numbers on
initialization. This prevents aperture numbers from growing to infinity if you
export several times to Gerber in the same GUI session. Acked-by: Andrew Poelstra * apoelstra AT wpsoftware dot net *
Acked-by: Peter Stuge * peter AT stuge dot se *
2013-04-13 Bert Timmerman * bert dot timmerman AT xs4all dot nl *
* src/hid/ps/ps.c: ps.c: correction in printer calibration. Reported-by: Stephen R. Besch * sbesch AT buffalo dot edu * Signed-off-by: Bert Timmerman * bert dot timmerman AT xs4all dot nl
*
2012-11-01 Bert Timmerman * bert dot timmerman AT xs4all dot nl *
* doc/gs/installation.texi: doc/gs/installation.texi: better use
"yum localinstall" to keep the updater synchronised. Corrected some typos. Signed-off-by: Bert Timmerman * bert dot timmerman AT xs4all dot nl
*
2012-04-18 Bert Timmerman * bert dot timmerman AT xs4all dot nl *
* doc/gs/installation.texi: doc/gs/installation.texi: Added a remark
about administrator-privileges. Signed-off-by: Bert Timmerman * bert dot timmerman AT xs4all dot nl
*
2012-01-11 Bert Timmerman * bert dot timmerman AT xs4all dot nl *
* doc/gs/installation.texi: doc/gs/installation.texi: Added
information how to install pcb on Fedora. Signed-off-by: Bert Timmerman * bert dot timmerman AT xs4all dot nl
*
2012-08-13 Kai-Martin Knaak * kmk AT lilalaser dot de *
* src/.gitignore: add parse_y.output to src/.gitignore Signed-off-by: Bert Timmerman * bert dot timmerman AT xs4all dot nl
*
2012-12-02 Sergey Alyoshin * alyoshin dot s AT gmail dot com *
* src/hid/gtk/ghid-cell-renderer-visibility.c: Don't localize signal
name Signed-off-by: Bert Timmerman * bert dot timmerman AT xs4all dot nl
*
2013-01-03 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/find.c: find.c: Remove some "flag" variable usage in DRCFind() Avoid confusion by passing *FLAG constants directly to some
functions. This removes several cases where we would set the
variable, use it once, then change it for the next usage, making the
code more succinct. I was not able to remove the flag variable entirely, as the while
loop calling DoIt() relies on it being changed inside the loop in
order to terminate. It should be possible to re-write the loop exit
condition if desired, but I'm not sure I completely understand the
behaviour of the existing code yet.
2013-01-03 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/find.c: find.c: Remove "flag" variable in DRCAll(), and pass
explicitly each time. This avoids confusion by making the flag passed to each call
clearer. It removes several cases where we would set the variable,
use it once, then change it for the next usage, making the code more
succinct.
2013-01-03 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/find.c: find.c: Fix flag passed to ListStart() in DRCFind(). We should have set the flag before calling ListStart(), as it marks
the first item with that flag.
2013-01-03 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/find.c: find.c: Fix possible un-assigned use of "flag" in
DRCFind(), fix bloated test. Caught by inspection.. no idea why the compiler didn't notice. Before commit 4cbfadfb7a496e60c25f47c88bdb374b4d3777bb, our local
"flag" variable was the file-global "TheFlag". If the "shrink" test
was not run, the code called ClearFlagOnAllObjects() with the
previously assigned "TheFlag". After the above commit, we would use
"flag" unassigned. If the shrink test is executed, the "FOUNDFLAG" is cleared from
objects, leaving a SELECTEDFLAG image on the copper in question as a
reference to compare against when considering the bloated geometry.
(This is the wrong reference, as we should be comparing against the
non-shrunk case). If the shrink test was not run, we left no reference for the boated
test. We should clear FOUNDFLAG _and_ SELECTEDFLAG after the shrunk test,
then construct a new reference to start with, using non-bloated
geometry. This partly fixes the behaviour of the bloated test, as it is now
run against a non-bloated reference, not a shrunk reference. This
fixes false reports of "Copper areas too close" for track objects
encountered after a "Potential for broken trace" warning. There are still other issues with the bloated DRC test. One
important one is that it may run multiple times on the same geometry
if a "Potential for broken trace" error is present, or if the
"shrink" test is not run. The repeated runs are because in the "Potential for broken trace"
case, only part of the track (or none if we skip the shrink test)
will get the DRCFLAG set. DRCFind then will be called repeatedly on
all pins, pads and vias, despite having already touched the geometry
with the bloated test. To fix this, we need to separate the shrink
and bloat tests into distinct passes, and set the DRCFLAG on objects
during both tests. We can't simply set the DRCFLAG from the bloated
test as it stands, as doing so would mask investigating "Potential
for broken trace" cases after the first encountered. An example of false "Copper areas too close" being fixed by this
commit is the following test-case: FileVersion[20091103] PCB["" 65.000mm 15.0000mm] Grid[984.251969 0.0000 0.0000 1] PolyArea[3100.006200]
Thermal[0.500000] DRC[0.5000mm 0.5000mm 0.5000mm 0.2500mm 0.4000mm
0.5000mm] Flags("nameonpcb,uniquename,clearnew,snappin")
Groups("1,c:2,s:3:4")
Styles["Signal,0.5000mm,1.0000mm,0.5000mm,0.2500mm:Power,25.00mil,60.00mil,35.00mil,10.00mil:Fat,40.00mil,60.00mil,35.00mil,10.00mil:Skinny,6.00mil,24.02mil,11.81mil,6.00mil"]Attribute("PCB::grid::unit" "mm") Attribute("PCB::grid::size"
"0.2500mm") Via[9.7500mm 7.2500mm 1.6000mm 0.5000mm 0.0000 0.5000mm "" ""]
Via[53.5000mm 7.2500mm 1.6000mm 0.5000mm 0.0000 0.5000mm "" ""]
Layer(1 "top") ( Line[9.7500mm 8.5000mm 28.0000mm 8.5000mm 0.5000mm 0.5000mm
"clearline"] Line[9.7500mm 7.2500mm 9.7500mm 8.5000mm 0.5000mm
0.5000mm "clearline"] Line[28.2500mm 8.5000mm 53.5000mm 8.5000mm
0.5000mm 0.5000mm "clearline"] Line[53.5000mm 7.2500mm 53.5000mm
8.5000mm 0.5000mm 0.5000mm "clearline"] ) Layer(2 "bottom") ( )
Layer(3 "silk") ( ) Layer(4 "silk") ( )
2013-01-03 DJ Delorie * dj AT delorie dot com *
* src/hid/png/png.c: png: --fill-holes Add an option to the PNG exporter to draw pin/via drill holes as
filled instead of hollow, for use with CNC machines that don't need
a "helper" hole in the copper. Also fixed a doc typo.
2013-01-03 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/find.c: find.c: Use SetThing, rather than open-coding
assignments to thing_* I'm trying to identify all uses of SetThing and similar consructs,
so I can eventually kill them.
2013-01-03 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/find.c: find.c: Remove unnecessary PIN/VIA test from
SetThing() This is not needed since commit
d581a90edc7fb7c0b4c6351611cc4a6689d7620b which put similar code into
ADD_PV_TO_LIST(), the only caller which could have previously
resulted in a SetThing call with the wrong type.
2013-01-03 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* configure.ac: configure.ac: Test for libgd once, not per HID which
uses it. This avoids some repeated tests, so should help to speed up the
configure process a little. This commit also enforces testing for
the required PNG support in libgd if the gcode or nelma HIDs are
selected.
2013-01-03 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* configure.ac: configure.ac: Remove CC_OR_CXX_FLAGS substitution
from configure.ac
2013-01-03 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/Makefile.am: src/Makefile.am: We don't gain anything by
setting AM_CFLAGS to C_OR_CXX_FLAGS We were duplicating command-line flags un-necessarily, and it does
not stop the a build with the C++ compiler using CFLAGS, as was (in
hindsight) the original intention before commit
72cdf2ecef3361a00fbd0ee3e540f7383e62272c where I changed a complete
CFLAGS override to a AM_CFLAGS addition. As we should not override CFLAGS in a Makefile (it prevents the user
from setting CFLAGS at "make" time), I'm removing this completely.
2013-01-03 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* configure.ac: configure.ac: Use CPPFLAGS, not CFLAGS for our
include directives. We were previously using CFLAGS for adding pre-processor includes,
where these should really end up in the CPPFLAGS variable.
Confusingly, their constituents tend to come from variables set by
autoconf / pkgconfig expansions in the form of LIBNAME_CFLAGS. Doing this allows the user to easily override CFLAGS at build time
without needing to replicate the enture include path list.
2013-01-03 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* configure.ac: configure.ac: Save and restore CPPFLAGS either side
of test for libgd Ensure we add GD_CFLAGS to the the main flag list later instead.
2013-01-03 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* configure.ac: configure.ac: Don't add GD_CFLAGS to CFLAGS, only
CPPFLAGS GD_CFLAGS will almost certainly contain pre-processor flags, not
strictly compiler flags, and we don't need to have a copy in CFLAGS
as well.
2013-01-03 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* configure.ac: configure.ac: Save and restore CPPFLAGS either side
of test for X11 stuff We add X_CFLAGS and X_LIBS to the main flag list later, so don't
leave an extra copy lying around in the CPPFLAGS variable.
2013-01-03 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* configure.ac: configure.ac: Don't copy CFLAGS into CPPFLAGS for
X11 tests CFLAGS should work in its own right, and CPPFLAGS does not need a
copy.
2013-01-03 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* configure.ac: configure.ac: Don't add win32 build flags to
CPPFLAGS as well as CFLAGS These are compiler flags only, not preprocessor flags.
2013-01-03 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* configure.ac: Remove CYGWIN_CFLAGS and CYGWIN_CPPFLAGS from
configure.ac We no longer ship a build-script which requries these. Any specific
CFLAGS for a given build should be overridden by specifying CFLAGS
at configure or make time.
2013-01-01 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/hid/gcode/gcode.c: hid/gcode: Add a more direct "#include
<locale.h>" for setlocale() The lack of this include caused a failure to build on my machine
when compiled without optimisation (-O0). With any optimisation
turned on, the build would work without the include. Having chased this strangeness down, it turns out that we were
including libintl.h via global.h, and that libintl.h includes
locale.h, IFF optimisation is turned on at the time it is
pre-processed.
2013-01-01 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/find.c: find.c: Remove some unnecessary includes.
2013-01-01 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/find.c: find.c: Move file-global "NumberOfPads" into the
function which uses it
2012-12-24 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/find.c: find.c: Pass flags to sub-functions without using
static variable "TheFlag".
2012-12-30 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/find.c: find.c: Remove some un-needed forward declarations of
static functions
2012-12-25 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/find.c, src/polygon.c, src/polygon.h: Refactor signature of
PlowsPolygon callback to take userdata This allows callers to pass arbitrary data into their callbacks
without resorting to nasty workarounds like global variables.
2012-12-30 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* : commit 6963cfda0ca661a7a1397ef5b54e418f76b89260 Author: Peter
Clifton * peter AT clifton-electronics dot co dot uk * Date: Mon
Dec 24 00:13:41 2012 +0000
2012-12-30 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/main.c: Change FOUND objects colour from green to purple... Aim to differentiate the region connected to the search origin from
those which should be (but are not yet) connected to it.
2012-12-10 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/action.c: Tag physically/logically connected items differently
in the "Find" action This commit restores the semantic meaning of the "found" flag to
what it was before commit 764c3560a722c768a7048f5c70811ec363862882,
and uses the "connected" flag to identify which of the "found"
(logically connected) items are physically connected to the search
origin. The aim here is to differentiate between what an ohm-meter would
show connected with the board as-currently designed, and what it
would read if all rat-lines were implemented.
2012-12-24 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/find.c: find.c: Use pointers to objects, not shallow copies of
their structures Since commit 4658e4074b4446337467f99fa2b8f9b7147e7e01, we don't
modify the copied objects, so we can use pointers instead.
2012-12-23 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/action.c, src/gpcb-menu.res.in, src/pcb-menu.res.in: Add
option to "Select" action, differentiating "FOUND" and "SELECTED"
objects The exising "Select" action included the variant
"Select(Connected)", which selected any object with the "FOUNDFLAG"
set. As we now make a distinction between logical and physical
connectivity (FOUND and SELECTED) respectively, this commit
introduces a split into "Select(Found)" and "Select(Connected)"
variants. There is a change here, in that "Select(Connected)" now acts on
objects with the CONNECTED flag set, (not the FOUND flag as it did
previously).
2012-12-23 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/draw.c, src/undo.h: draw.c: Support for coloring objects with
CONNECTEDFLAG set We now color objects with the FOUNDFLAG set in the FoundColor, not
the ConnectedColor as we did previously. Unsurprisingly, objects
with the CONNECTEDFLAG set get rendered in the ConnectedColor. CONNECTEDFLAG is tested before FOUNDFLAG, and takes precidence if an
object has both flags set.
2012-12-23 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/create.c, src/global.h, src/main.c: Add FoundColor to resource
settings, distinct from the Connected color For now, set ConnectedColour and FoundColor to the same green, so we
can introduce this patch series without flip-flopping the renderered
colours.
2012-12-22 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/const.h, src/strflags.c: Add a new flag, "connected" /
CONNECTEDFLAG. The intended use of this flag is to mark physical connections.
2012-12-22 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/find.c: find.c: Avoid adding any rat-lines at all when AndRats
is false. Previously we were adding some rat-lines when searching for physical
connections. We should stop at the physical->rat boundary, not the
opposite end of the ratline.
2012-12-23 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/find.c: find.c: Fix inverted logic in LookupConnection() When AndRats is true, we may consider starting with a ratline
object, otherwise we do no. I got this backwards by mistake.
2012-12-25 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/find.c: find.c: Remove file-global "IsBad", use
PlowsPolygons() return value. This variable was used to communicate state from the drc_callback(),
however PlowsPolygons() returns the sum of the values returned by
its callback function. As our callback returns 0 on success, 1 on
DRC failure, we know any non-zero return from PlowsPolygons()
implies a DRC problem.
2012-12-24 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/find.c: find.c: Avoid modifying bounds of the objects we are
passing down Bloat the bounding box into a local BoxType structure instead, to
avoid passing inconsistent objects to lower level functions.
2012-12-27 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/find.c: find.c: Avoid repeated lookup of layer pointer by
number Rename a few "layer" varaibles to "layer_no", and re-use "layer"
where necessary as a LayerType *, rather than a Cardinal.
2012-12-24 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/find.c: find.c: Tidy up some macro definitions (Whitespace only changes)
2012-12-24 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/find.c: find.c: Remove unused function pv_touch_callback()
2012-12-24 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/action.c: action.c: Fix drawing lines on silkscreen with
auto-enforce DRC enabled The auto-enforce DRC code was not incorrectly setting FOUNDFLAG on
one of each pair of line-segments drawn with a mouse-click. Completes the fix from commit
aa7196dc29a761ecddda1a40d68fedf39ab78c31 Affects-bug: lp-699291
2012-12-23 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/action.c, src/find.c, src/find.h,
src/hid/gtk/gui-drc-window.c, src/hid/gtk/gui-netlist-window.c,
src/hid/lesstif/netlist.c, src/rats.c, src/report.c, src/select.c,
src/set.c: Rename ResetFound{LinesAndPolygons,PinsViasAndPads} and
ResetConnections These functions are not specific to the "found" flag, (or the soon
to be introduced "connected" flag, so to avoid confusion, rename
them: ClearFlagOnLinesAndPolygons () ClearFlagOnPinsViasAndPads () ClearFlagOnAllObjects ()
2012-12-23 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/buffer.c, src/const.h, src/copy.c: Add #define list of flags
to unset when copying into a buffer Previously, the removal of FOUNDFLAG was hard-coded in various
places, lets consolidate the location to one header file, as when we
split the FOUNDFLAG to differentiate logical and physical
connectivity, we will only have one location to update.
2012-12-23 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/hid/gtk/gui-drc-window.c: hid/gtk/gui-drc-window.c: Refactor
unset_found_flags() to use ResetConnections() There is a lot of code in this function which matches
ResetConnections(), we only need to take care of the undo buffer
management at the end.
2012-12-23 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/const.h: const.h: Re-indent flags with spaces, rather than
tabs Whitespace only change. Allows adding flags with longer hex-strings
without having to shuffle the indenting too much.
2012-12-23 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/const.h: const.h: Fix flag documentation for the NOPASTE flag We were listing the wrong flag value for this flag.
2012-12-19 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/find.c: find.c: Refactor some duplicated code for adding
objects to various lists
2012-12-22 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/hid/gtk/gtkhid-gl.c: hid/gtk: (GL) Disable scissor test for
pinout preview widget. The partial drawing is interacting badly with our double-buffering,
as we are not painting the entire buffer we are swapping onto the
screen. I have left a comment and some debug code, as this may need
revisiting to address what is really going on here.
2012-12-22 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/hid/gtk/gtkhid-gl.c: hid/gtk: Disable GL alpha-blending for
the pinout preview We aren't using subcompositing for this, so don't alpha-blend.
2012-12-23 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/hid/gtk/gtkhid-gl.c: hid/gtk: (GL) Start with the stencil test
disabled in all rendering Keep the pinout preview and pixmap rendering paths as close as
possible to the main drawing window one. There was probably no real
issue here, but it doesn't hurt to be consistent.
2012-12-22 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/hid/gtk/gtkhid-gl.c: hid/gtk: Use common GL setup and teardown
code for different expose paths
2012-12-22 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/buffer.c, src/copy.c, src/create.c, src/create.h,
src/parse_y.y: create.c: Remove Element parameter to
CreateNewElement() Lets always make a new element, not re-use old memory. It seems
saner to do this when we have an API with "New" in the name! No callers use the facility to fill in a pre-allocated (or already
used) ElementType structure any more.
2012-12-22 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/parse_y.y: parse_y.y: Pass NULL explicitly to
CreateNewElement(), rather than via yyElement This makes things clearer.
2012-12-22 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/buffer.c, src/copy.c, src/copy.h,
src/hid/gtk/gui-pinout-preview.c: copy.c: Remove "Dest" variable to
CopyElementLowLevel() function We no longer require this, as all callers pass NULL in order that
CopyElementLowLevel() allocates memory for the new element.
2012-12-22 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/buffer.c: AddElementToBuffer(): Let CopyElementLowLevel()
create the element to copy into.
2012-12-22 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/hid/gtk/gtkhid-gdk.c, src/hid/gtk/gtkhid-gl.c,
src/hid/gtk/gui-pinout-preview.c, src/hid/gtk/gui-pinout-preview.h:
hid/gtk: Make the pinout preview element use dynamicly allocated
memory. By embedding the element structure in our data-structure, we were
forcing various element initialisation and copy routines to be
require operating on a pre-allocated ElementType - rather than just
returning us a pointer to a newly allocated ElementType.
2012-12-22 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/mymem.c: mymem.c: Allow elements to exist independently of a
buffer. If the DataType pointer to GetElementMemory is NULL, we allocate
memory but don't add to the buffer's element list or counters. This is useful as it will allow rendering of pinout previews without
needing separate (or static) memory allocation to hold the previewed
Element.
2012-12-22 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/draw.c: draw.c: Always draw pin / hole names when in pinout
preview This was removed a long time ago by mistake when refactoring some of
this drawing code, and causes missing text in the Lesstif HID pinout
preview.
2012-12-22 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/hid/common/extents.c: hid/common: Fix extents computation in
nm units We still had some fallout from the nm units conversion here, using
MAXINT rather than COORD_MAX for some bounds checking. This was completely breaking the lesstif HID pinout preview window.
2012-12-22 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/buffer.c, src/copy.c, src/copy.h,
src/hid/gtk/gui-pinout-preview.c: copy.c: Add mask_flags parameter
to CopyElementLowLevel() This avoids us needing to unset ExtraFlags separately in buffer.c
2012-12-22 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/action.c, src/hid/gtk/gui-netlist-window.c,
src/hid/lesstif/netlist.c, src/select.c, src/select.h: select.c:
Rename SelectConnection() to SelectByFlag() and add flag parameter
2012-12-22 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/select.c: select.c: Rename "Flag" to "select" for clarity. This will help avoid confusion when adding a "flag" parameter to
specify which flag to check in SelectConnection().
2012-12-19 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/find.c, src/find.h: find.c: Make some setup / teardown
functions not used outside of find.c static. This makes the following functions private to find.c: InitComponentLookup FreeComponentLookupMemory InitLayoutLookup FreeLayoutLookupMemory
2012-12-18 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/find.c, src/find.h: find.c: Remove unused APIs SaveFindFlag()
and RestoreFindFlag() The find.c APIs which require flags setting up now take the flag as
a function parameter.
2012-12-18 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/hid/gtk/gui-netlist-window.c, src/hid/lesstif/netlist.c,
src/rats.c, src/select.c: Remove calls to SaveFindFlag() These were needed before our APIs specified which flags they
operated on, but are now redundant. All entrypoints in find.c which
use flags now set the flag before commencing work.
2012-12-18 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/find.c, src/find.h, src/hid/gtk/gui-netlist-window.c,
src/hid/lesstif/netlist.c, src/rats.c, src/select.c: find.c: Add
flag parameter to RatFindHook() API. This saves us having to expose an API to save and restore the find.c
static "theFlag" variable. The key difference (once the save/restore are removed), is that we
then won't restore "TheFlag" variable after we are done. This will
not matter as all entry-points in find.c now take a flag parameter
and there should not be reentrancy in these calls.
2012-12-16 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/hid/batch/batch.c: hid/batch: Add missing #include
"hid_draw.h" I should have built-tested all HIDs when I refectored this.. oops.
2012-12-16 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/hid/lesstif/main.c: hid/lesstif: Fix incorrect structure
assignment due to bad refactoring. I should have built-tested all HIDs when I refectored this.. oops. Reported-by: Ralf Gerbig * rge AT quengel dot org *
2012-12-15 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/find.c, src/find.h: find.c: Make
Is{Arc,Line,Pad,Polygon}InPolygon() functions static These are only used from within find.c, so make them static so the
compiler is more free to optimise their usage.
2012-12-15 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/find.c: Remove unused functions {LO,PV}TouchesLine() and their
callbacks Unused since we removed the unused function clearLine()
2012-12-15 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/find.c, src/find.h: find.c: Remove unused function lineClear()
2012-12-14 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/action.c, src/find.c, src/find.h,
src/hid/gtk/gui-netlist-window.c, src/hid/lesstif/netlist.c,
src/rats.c, src/report.c, src/select.c, src/set.c: Add flag
parameters to ResetFound{LinesAndPolygons,PinsViasAndPads},
ResetConnections This avoids relying on the state to be magically correct
2012-12-14 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/autoroute.c: autoroute.c: Remove setting the Find flag to
DRCFLAG We don't use the find features directly, those we do already take
care of setting the appropriate flag.
2012-12-14 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/find.c: find.c: Set TheFlag to FOUNDFLAG explicitly in
LookupUnusedPins() We relied on it being set to an appropriate value, instead set it to
FOUNDFLAG, similar to how LookupElementConnections() does.
2012-12-14 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/hid/gtk/gui-netlist-window.c, src/hid/lesstif/netlist.c: (GTK, Lesstif): Netlist window - Set find flag to FOUNDFLAG
explicitly Our "Select net" functionality depends on find.c's "TheFlag"
variable being set to FOUNDFLAG. In some circumstances (e.g. after a
DRC check), this may not be the case, and selecting nets from the
netlist window breaks.
2012-12-14 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/select.c: select.c: Set an explicit flag to search using when
selecting nets by name If find.c's "TheFlag" variable is not equal to FOUNDFLAG, our code
for selecting nets by name did not work. This could happen, for
example - after a DRC check, where "TheFlag" appears to be left
equal to SELECTEDFLAG.
2012-12-14 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/toporouter.c: toporouter.c: Remove un-necessary call to
ResetConnections() This is not required by the call to CollectSubnets() which follows
it, and we don't have any other requirement to clear flags. Futhermore, as toporouter.c does not setup which flag is being
operated on, the effect of this call will depend on which flag has
been left in "TheFlag" variable in find.c.
2012-12-14 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/autoroute.c: autoroute.c: Remove unnecessary call to
ResetConnections() This is not required to call CollectSubnets, (as the rats.c internal
function GatherSubnets() cleans the flag from objects before it uses
it). We also use DRCFLAG to mark nets in CreateRouteData(), however: 1. We should be able to assume the DRCFLAG is clear on all objects
at the point we un-necessary to reset it. 2. We call GatherSubnets() after we reset the DRCFLAG contents, and that leaves the objects in a clean state without that flag set.
2012-12-13 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/hid/ps/ps.c: hid/ps: Add support for rendering "fullpoly"
polygons Affects-bug: lp-1089532
2012-12-13 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/hid/common/draw_helpers.c: hid/common/draw_helpers.c: Fix
thindraw for "fullpoly" polygons Affects-bug: lp-1089532
2012-12-13 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/hid/common/hidgl.c: hid/common/hidgl.c: Add support for
rendering "fullpoly" polygons This finally bit someone (and eneded up with them producing a bad
batch of boards), so it is about time I fixed this. Affects-bug: lp-1089532
2012-12-07 Kevin Redon * kevredon AT mail dot tsaitgaist dot info *
* src/create.c: Don't merge lines with different clearances When multiple lines (with same direction, thickness, and clear
flags) are moved, they are merged into one line. We should also
check the line clearances match to ensure the lines are suitable for
merging. [Commit message re-worded by Peter Clifton] Signed-off-by: Kevin Redon * kevredon AT mail dot tsaitgaist dot
info *
2012-12-02 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/hid/common/hidgl.c: hid/common/hidgl.c: Make (polygon->clipped
== NULL) test silent This is the case for other implementations of this API, so we should
aim to be consistent.
2012-12-02 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/draw.c, src/hid/common/draw_helpers.c: Move polygon->Clipped
test into the HID implementations which require it. This keeps draw.c more consistent between object types.
2012-12-02 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/hid/gtk/gtkhid-gl.c: hid/gtk: Call ghid_fill_pcb_polygon via
(HID_DRAW *)->fill_pcb_polygon() This indirection allows a more graceful fallback in the case where
we run out of stencil bits and replace our (HID_DRAW
*)->fill_pcb_polygon() vfunc pointer with the
common_fill_pcb_polygon() implementation.
2012-12-02 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/draw.c, src/hid/common/draw_helpers.c,
src/hid/common/draw_helpers.h, src/hid/common/hidnogui.c,
src/hid/gtk/gtkhid-main.c, src/hid/lesstif/main.c, src/hid/ps/ps.c,
src/hid_draw.h: Add (HID_DRAW *)->draw_pcb_polygon() API This pushes special case thindraw vs. fill handling out of the core,
and into each individual HID implementation. We retain the old
implementation as a helper function, common_gui_draw_pcb_polygon()
in hid/common/draw_helpers.c. This keeps the API more consistent between polygons and other object
types by introducing the new (HID_DRAW *)->draw_pcb_polygon() API. I've left the (HID_DRAW *)->{fill,thindraw}_pcb_polygon() APIs for
now, as it means we can avoid a little code duplucation between the
GUIs. We may consider removing (or hiding) these APIs at some point,
as they are now _NOT_ intended to be called from outside of the
GUI's (HID_DRAW *)->draw_pcb_polygon() implementation.
2012-12-02 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/hid/common/draw_helpers.c, src/hid/common/draw_helpers.h:
hid/common: Fix including draw_helpers.h from draw_helpers.c The prototype for hid_common_fill_pcb_pv() was incorrect. To avoid
this kind of mistake in the future, include the header file from the
.c file.
2012-11-24 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/draw.c: draw.c: Collapse line and arc drawing wrapper
functions into only callers
2012-11-24 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/draw.c, src/draw.h, src/hid/common/draw_helpers.c,
src/hid_draw.h, src/print.c: Move DrawTextLowlevel() routine from
draw.c into the HID_DRAW API The API is now called draw_pcb_text, and the default implementation
resides in hid/common/draw_helpers.c
2012-11-24 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/draw.c, src/hid/common/draw_helpers.c, src/hid_draw.h: Move
_draw_arc() routine from draw.c into HID_DRAW API The API is now called draw_pcb_arc, and the default implementation
resides in hid/common/draw_helpers.c
2012-11-24 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/draw.c, src/hid/common/draw_helpers.c, src/hid_draw.h: Move
_draw_line() routine from draw.c into HID_DRAW API The API is now called draw_pcb_line, and the default implementation
resides in hid/common/draw_helpers.c
2012-11-24 Peter Clifton * peter AT clifton-electronics dot co dot uk *
* src/hid/common/hidgl.c: hidgl: Fixup signature gluTessCallback
functions to work on Win32 On windows these callbacks are invoked using stdcall calling
convention and we need to annotate then with the "CALLBACK" macro to
achieve this. If we ever end up using glew.h, we can probably drop the #ifndef
CALLBACK check which #defines CALLBACK to an empty string on other
platforms.
2012-11-23 Eugene Mikhantiev * mikhantiev AT gmail dot com *
* src/Makefile.am: Add hid_draw.h to PCB_SRC in Makefile Signed-off-by: Bert Timmerman * bert dot timmerman AT xs4all dot nl
*
2012-11-23 Markus Hitter * mah AT jump-ing dot de *
* tests/golden/hid_gcode1/Makefile.am,
tests/golden/hid_gcode1/gcode_oneline-drillmill.gcode,
tests/golden/hid_gcode10/gcode_oneline-drillmill.gcode,
tests/golden/hid_gcode11/Makefile.am,
tests/golden/hid_gcode11/gcode_oneline-drillmill.gcode,
tests/golden/hid_gcode2/Makefile.am,
tests/golden/hid_gcode2/out-drillmill.gcode,
tests/golden/hid_gcode3/Makefile.am,
tests/golden/hid_gcode3/gcode_oneline-drillmill.gcode,
tests/golden/hid_gcode4/Makefile.am,
tests/golden/hid_gcode4/gcode_oneline-drillmill.gcode,
tests/golden/hid_gcode5/Makefile.am,
tests/golden/hid_gcode5/gcode_oneline-drillmill.gcode,
tests/golden/hid_gcode6/Makefile.am,
tests/golden/hid_gcode6/gcode_oneline-drillmill.gcode,
tests/golden/hid_gcode7/Makefile.am,
tests/golden/hid_gcode7/gcode_oneline-drillmill.gcode,
tests/golden/hid_gcode8/Makefile.am,
tests/golden/hid_gcode8/gcode_oneline-drillmill.gcode,
tests/golden/hid_gcode9/gcode_oneline-drillmill.gcode,
tests/tests.list: gcode HID: regenerate the test files. This covers the fixes introduced in the last three commits and also
removes a number of golden output files.
2012-11-23 Markus Hitter * mah AT jump-ing dot de *
* src/hid/gcode/gcode.c: gcode HID: distribute drillmill radius' to
all drills. Previously, it was distributed to only the first of it's size.
2012-11-22 Markus Hitter * mah AT jump-ing dot de *
* src/hid/gcode/gcode.c: gcode HID: don't write "empty" drillmill
files. All changes except the first and the last line are whitespace
changes. Closes-bug: lp-1074196
2012-11-22 Markus Hitter * mah AT jump-ing dot de *