Skip to content

Commit 88ea142

Browse files
committed
fixing updating wrong image adjustments.... wip
1 parent a1ffbd4 commit 88ea142

File tree

2 files changed

+32
-9
lines changed

2 files changed

+32
-9
lines changed

MyCBZ/Forms/MainForm.cs

Lines changed: 27 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -348,7 +348,7 @@ private void NewProject()
348348
selectedImageTasks = Program.ProjectModel.GlobalImageTask;
349349
GlobalAlertTableLayout.Visible = false;
350350

351-
UpdateImageAdjustments(null, "<Global>");
351+
UpdateImageAdjustments(null, "<Global>", true);
352352
}));
353353

354354
ClearLog();
@@ -425,7 +425,7 @@ private void OpenToolStripMenuItem_Click(object sender, EventArgs e)
425425
TextBoxExcludePagesImageProcessing.Text = "";
426426
RenamerExcludePages.Text = "";
427427
PageCountStatusLabel.Text = "0 Pages";
428-
UpdateImageAdjustments(sender, "<Global>");
428+
UpdateImageAdjustments(sender, "<Global>", true);
429429
Program.ProjectModel.IsChanged = false;
430430
Program.ProjectModel.Pages.Clear();
431431
}));
@@ -4014,15 +4014,16 @@ private void PagesList_ItemSelectionChanged(object sender, ListViewItemSelection
40144014
}
40154015

40164016
selectedImageTasks = ((Page)selectedPages[0].Tag).ImageTask;
4017+
4018+
if (RadioApplyAdjustmentsPage.Checked && RadioApplyAdjustmentsPage.Tag != ((Page)selectedPages[0].Tag).Id)
4019+
{
4020+
UpdateImageAdjustments(sender, ((Page)selectedPages[0].Tag).Id, true);
4021+
}
40174022

40184023
RadioApplyAdjustmentsPage.Text = ((Page)selectedPages[0].Tag).Name;
40194024
RadioApplyAdjustmentsPage.Tag = ((Page)selectedPages[0].Tag).Id;
40204025
RadioApplyAdjustmentsPage.Enabled = true;
40214026

4022-
if (RadioApplyAdjustmentsPage.Checked)
4023-
{
4024-
UpdateImageAdjustments(sender, ((Page)selectedPages[0].Tag).Id);
4025-
}
40264027
//RequestImageInfoSlice();
40274028
}
40284029
else
@@ -5014,6 +5015,9 @@ private void ImageResizeRadioChanged(object sender, EventArgs e)
50145015

50155016
if (selectedImageTasks != null)
50165017
{
5018+
Page selectedPage = PagesList.SelectedItem?.Tag as Page;
5019+
bool dontUpdate = radio.Tag != null ? ((bool)radio.Tag) : true;
5020+
50175021
Page page = Program.ProjectModel.GetPageById(selectedImageTasks.PageId);
50185022
oldValue = page?.ImageTask.ImageAdjustments.ResizeMode;
50195023

@@ -5033,7 +5037,7 @@ private void ImageResizeRadioChanged(object sender, EventArgs e)
50335037
break;
50345038
}
50355039

5036-
if (page != null && oldValue != null && oldValue != selectedImageTasks.ImageAdjustments.ResizeMode)
5040+
if (!dontUpdate && page != null && oldValue != null && oldValue != selectedImageTasks.ImageAdjustments.ResizeMode)
50375041
{
50385042
AppEventHandler.OnPageChanged(this, new PageChangedEvent(page, null, PageChangedEvent.IMAGE_STATUS_CHANGED, true));
50395043
}
@@ -5079,10 +5083,13 @@ private void RadioApplyAdjustments_CheckedChanged(object sender, EventArgs e)
50795083
if (rb.Checked)
50805084
{
50815085
UpdateImageAdjustments(sender, selected);
5086+
} else
5087+
{
5088+
UpdateImageAdjustments(sender, selected, true);
50825089
}
50835090
}
50845091

5085-
private void UpdateImageAdjustments(object sender, string selected)
5092+
private void UpdateImageAdjustments(object sender, string selected, bool dontUpdate = false)
50865093
{
50875094
ImageTask selectedTask = null;
50885095
Page page = null;
@@ -5113,20 +5120,24 @@ private void UpdateImageAdjustments(object sender, string selected)
51135120
{
51145121

51155122
Invoke(new Action(() =>
5116-
{
5123+
{
51175124
//ImageQualityTrackBar.Value = selectedTask.ImageAdjustments.Quality;
51185125
switch (selectedImageTasks.ImageAdjustments.ResizeMode)
51195126
{
51205127
case 0:
5128+
RadioButtonResizeNever.Tag = dontUpdate;
51215129
RadioButtonResizeNever.Checked = true;
51225130
break;
51235131
case 1:
5132+
RadioButtonResizeIfLarger.Tag = dontUpdate;
51245133
RadioButtonResizeIfLarger.Checked = true;
51255134
break;
51265135
case 2:
5136+
RadioButtonResizeTo.Tag = dontUpdate;
51275137
RadioButtonResizeTo.Checked = true;
51285138
break;
51295139
case 3:
5140+
RadioButtonResizePercent.Tag = dontUpdate;
51305141
RadioButtonResizePercent.Checked = true;
51315142
break;
51325143

@@ -5219,6 +5230,7 @@ private void CheckboxKeepAspectratio_CheckedChanged(object sender, EventArgs e)
52195230

52205231
if (selectedImageTasks != null)
52215232
{
5233+
Page selectedPage = PagesList.SelectedItem?.Tag as Page;
52225234
Page page = Program.ProjectModel.GetPageById(selectedImageTasks.PageId);
52235235
oldValue = page?.ImageTask.ImageAdjustments.KeepAspectRatio;
52245236

@@ -5300,6 +5312,7 @@ private void TextBoxResizeH_TextChanged(object sender, EventArgs e)
53005312

53015313
if (selectedImageTasks != null)
53025314
{
5315+
Page selectedPage = PagesList.SelectedItem?.Tag as Page;
53035316
Page page = Program.ProjectModel.GetPageById(selectedImageTasks.PageId);
53045317
oldValue = page?.ImageTask.ImageAdjustments.ResizeTo.Y;
53055318

@@ -5352,6 +5365,7 @@ private void TextboxResizePercentage_TextChanged(object sender, EventArgs e)
53525365

53535366
if (selectedImageTasks != null)
53545367
{
5368+
Page selectedPage = PagesList.SelectedItem?.Tag as Page;
53555369
Page page = Program.ProjectModel.GetPageById(selectedImageTasks.PageId);
53565370
oldValue = page?.ImageTask.ImageAdjustments.ResizeToPercentage;
53575371

@@ -5397,6 +5411,7 @@ private void CheckBoxDontStretch_CheckedChanged(object sender, EventArgs e)
53975411

53985412
if (selectedImageTasks != null)
53995413
{
5414+
Page selectedPage = PagesList.SelectedItem?.Tag as Page;
54005415
Page page = Program.ProjectModel.GetPageById(selectedImageTasks.PageId);
54015416
oldValue = page?.ImageTask.ImageAdjustments.DontStretch;
54025417

@@ -5422,6 +5437,7 @@ private void TextBoxSplitPageAt_TextChanged(object sender, EventArgs e)
54225437

54235438
if (selectedImageTasks != null)
54245439
{
5440+
Page selectedPage = PagesList.SelectedItem?.Tag as Page;
54255441
Page page = Program.ProjectModel.GetPageById(selectedImageTasks.PageId);
54265442
oldValue = page?.ImageTask.ImageAdjustments.SplitPageAt;
54275443

@@ -5455,6 +5471,7 @@ private void ComboBoxSplitAtType_SelectedIndexChanged(object sender, EventArgs e
54555471

54565472
if (selectedImageTasks != null)
54575473
{
5474+
Page selectedPage = PagesList.SelectedItem?.Tag as Page;
54585475
Page page = Program.ProjectModel.GetPageById(selectedImageTasks.PageId);
54595476
oldValue = page?.ImageTask.ImageAdjustments.SplitPageAt;
54605477

@@ -5479,6 +5496,7 @@ private void CheckBoxSplitDoublePages_CheckedChanged(object sender, EventArgs e)
54795496

54805497
if (selectedImageTasks != null)
54815498
{
5499+
Page selectedPage = PagesList.SelectedItem?.Tag as Page;
54825500
Page page = Program.ProjectModel.GetPageById(selectedImageTasks.PageId);
54835501
oldValue = page?.ImageTask.ImageAdjustments.SplitPage;
54845502

MyCBZ/Models/Page.cs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2353,5 +2353,10 @@ public void FreeImage()
23532353

23542354
Invalidated = true;
23552355
}
2356+
2357+
public override string ToString()
2358+
{
2359+
return Name;
2360+
}
23562361
}
23572362
}

0 commit comments

Comments
 (0)