Correct OO hierarchy (virtual dtors)

Author: taehyounpark

include/queryosity/column.h

@@ -13,7 +13,11 @@ namespace queryosity {
  */
 namespace column {
 
-class node : public action {};
+class node : public action {
+  public:
+    node() = default;
+    virtual ~node() = default;
+};
 
 //---------------------------------------------------
 // view can actually report on the concrete data type

include/queryosity/column_evaluator.h

@@ -15,7 +15,7 @@ template <typename T> class column::evaluator {
 
 public:
   template <typename... Args> evaluator(Args const &...args);
-  ~evaluator() = default;
+  virtual ~evaluator() = default;
 
   template <typename... Vals>
   std::unique_ptr<T> evaluate(view<Vals> const &...cols) const;

include/queryosity/dataset_processor.h

@@ -11,7 +11,7 @@ namespace dataset {
 class processor : public multithread::core, public ensemble::slotted<player> {
 public:
   processor(int suggestion);
-  ~processor() = default;
+  virtual ~processor() = default;
 
   processor(const processor &) = delete;
   processor &operator=(const processor &) = delete;

include/queryosity/lazy_varied.h

@@ -29,7 +29,7 @@ class lazy<Act>::varied : public dataflow::node,
 
 public:
   varied(lazy<Act> nom);
-  ~varied() = default;
+  virtual ~varied() = default;
 
   varied(varied const &) = default;
   varied &operator=(varied const &) = default;

include/queryosity/multithread.h

@@ -54,7 +54,7 @@ class core {
   core(const core &) = default;
   core &operator=(const core &) = default;
 
-  ~core() = default;
+  virtual ~core() = default;
 
   /**
    * @brief Run the function on the underlying slots, multi-threading if

include/queryosity/query_output.h

@@ -26,6 +26,7 @@ template <typename Qry> class output {
    * @param args Constructor arguments.
    */
   template <typename... Args> output(Args const &...args);
+  ~output() = default;
 
   auto make(dataflow &df) const;
 

include/queryosity/selection_applicator.h

@@ -17,7 +17,7 @@ class selection::applicator : public column::evaluator<Def> {
 
 public:
   template <typename... Args> applicator(selection::node const *prev, Args const &...args);
-  ~applicator() = default;
+  virtual ~applicator() = default;
 
   template <typename... Vals>
   std::pair<std::unique_ptr<Sel>, std::unique_ptr<Def>>

include/queryosity/systematic_nominal.h

@@ -12,7 +12,7 @@ template <typename Lzy> class nominal {
 
 public:
   nominal(Lzy const &nom);
-  virtual ~nominal() = default;
+  ~nominal() = default;
 
   auto get() const -> Lzy const &;
 

include/queryosity/systematic_variation.h

@@ -14,7 +14,7 @@ template <typename Lazy> class systematic::variation {
 
 public:
   variation(const std::string &name, Lazy const &var);
-  virtual ~variation() = default;
+  ~variation() = default;
 
   auto name() const -> std::string;
   auto get() const -> Lazy const &;