Get rid of customization (clunky)

Author: taehyounpark

examples/example-03.cxx

@@ -64,7 +64,7 @@ int main() {
   // :(
 
   auto n_f_best =
-      df.define(column::definition<Factorial>(20), column::customization([](Factorial* n_f_best){n_f_best->change_threshold(10);}))(n, n_f_fast, n_f_full);
+      df.define(column::definition<Factorial>(n_threshold))(n, n_f_fast, n_f_full);
   // time elapsed = t(n) + { t(n_fast) if n >= 10, t(n_slow) if n < 10 }
   // :)
 }

include/queryosity/column.h

@@ -172,8 +172,6 @@ template <typename T> struct constant;
 
 template <typename T> struct expression;
 
-template <typename T> struct customization;
-
 template <typename T> struct series;
 
 template <typename T>

include/queryosity/column_customization.h

@@ -5,7 +5,6 @@
 #include <type_traits>
 
 #include "action.h"
-#include "column_customization.h"
 
 namespace queryosity {
 
@@ -20,14 +19,11 @@ template <typename T> class evaluator {
   template <typename... Args> evaluator(Args const &...args);
   virtual ~evaluator() = default;
 
-  void patch(std::function<void(T *)> fn);
-
   template <typename... Vals>
   std::unique_ptr<T> evaluate(view<Vals> const &...cols) const;
 
 protected:
   std::function<std::unique_ptr<T>()> m_make;
-  std::function<void(T *)> m_patch;
 };
 } // namespace column
 
@@ -36,22 +32,13 @@ template <typename T> class evaluator {
 template <typename T>
 template <typename... Args>
 queryosity::column::evaluator<T>::evaluator(Args const &...args)
-    : m_make(std::bind(
-          [](Args const &...args) { return std::make_unique<T>(args...); },
-          args...)),
-      m_patch([](T *) {}) {}
-
-template <typename T>
-void queryosity::column::evaluator<T>::patch(std::function<void(T *)> fn) {
-  m_patch = std::move(fn);
-}
+    : m_make([args...]() { return std::make_unique<T>(args...); }) {}
 
 template <typename T>
 template <typename... Vals>
 std::unique_ptr<T>
 queryosity::column::evaluator<T>::evaluate(view<Vals> const &...columns) const {
   auto defn = m_make();
-  this->m_patch(defn.get());
   defn->set_arguments(columns...);
   return defn;
 }

include/queryosity/column_evaluator.h

@@ -133,21 +133,6 @@ class dataflow {
   auto define(column::definition<Def> const &defn)
       -> todo<column::evaluator<Def>>;
 
-  /**
-   * @brief Define a column using an expression.
-   * @tparam Def Custom definition.
-   * @tparam Fn Custom patch. It *must* be a void function whose sole argument is `Def*`.
-   * @param[in] defn Definition type and constructor arguments.
-   * @param[in] patch Patch function to run on the created instance(s) of column definition.
-   * @detail The patch function can be used to access any public member
-   * variables and/or functions of a custom column definition to "configure" it
-   * beyond constructor arguments.
-   * @return Evaluator.
-   */
-  template <typename Def, typename Fn>
-  auto define(column::definition<Def> const &defn, column::customization<Fn> const& patch)
-      -> todo<column::evaluator<Def>>;
-
   /**
    * @brief Select all entries.
    * @return Lazy selection with cut passing for all entries and weight equal to
@@ -496,18 +481,6 @@ auto queryosity::dataflow::define(column::definition<Def> const &defn)
   return this->_define(defn);
 }
 
-template <typename Def, typename Fn>
-auto queryosity::dataflow::define(column::definition<Def> const &defn, column::customization<Fn> const& custom)
-    -> todo<column::evaluator<Def>> {
-  auto eval = this->_define(defn);
-  ensemble::invoke(
-      [&custom](column::evaluator<Def> *eval) {
-        custom.patch(eval);
-      },
-      eval.get_slots());
-  return eval;
-}
-
 template <typename Col>
 auto queryosity::dataflow::filter(lazy<Col> const &col)
     -> lazy<selection::node> {