Remove leaky abstraction

Author: taehyounpark

include/queryosity.h

@@ -28,6 +28,4 @@
 #include "queryosity/todo.h"
 #include "queryosity/todo_varied.h"
 
-#include "queryosity/systematic_vary.h"
-
 namespace qty = queryosity;

include/queryosity/action.h

@@ -4,7 +4,7 @@
 
 namespace queryosity {
 
-class action : public systematic::mode {
+class action {
 
 public:
   action() = default;

include/queryosity/dataflow.h

@@ -397,9 +397,7 @@ class dataflow::node {
 #include "column_variation.h"
 #include "query_output.h"
 
-#include "systematic_nominal.h"
 #include "systematic_resolver.h"
-#include "systematic_variation.h"
 
 inline queryosity::dataflow::dataflow()
     : m_processor(multithread::disable()), m_weight(1.0), m_nrows(-1),

include/queryosity/dataset_loaded.h

@@ -41,7 +41,6 @@ template <typename DS> class loaded {
 #include "dataset_column.h"
 #include "lazy.h"
 #include "lazy_varied.h"
-#include "systematic_variation.h"
 
 template <typename DS>
 queryosity::dataset::loaded<DS>::loaded(queryosity::dataflow &df, DS &ds)

include/queryosity/lazy_varied.h

@@ -161,9 +161,6 @@ queryosity::varied<queryosity::lazy<Act>>::operator=(
 template <typename Act>
 void queryosity::varied<queryosity::lazy<Act>>::set_variation(
     const std::string &var_name, queryosity::lazy<Act> var) {
-  ensemble::invoke(
-      [var_name](action *act) { act->set_variation_name(var_name); },
-      var.get_slots());
   m_var_map.insert(std::make_pair(var_name, std::move(var)));
   m_var_names.insert(var_name);
 }

include/queryosity/systematic.h

@@ -15,25 +15,6 @@ auto get_variation_names(Nodes const &...nodes) -> std::set<std::string>;
 
 template <typename Node> class resolver;
 
-template <typename Lzy> class variation;
-
-template <typename Lzy> class nominal;
-
-class mode {
-public:
-  mode();
-  ~mode() = default;
-
-  void set_variation_name(const std::string &var_name);
-
-  bool is_nominal() const;
-  std::string variation_name() const;
-
-protected:
-  bool m_is_nominal;
-  std::string m_variation_name;
-};
-
 } // namespace systematic
 
 } // namespace queryosity
@@ -44,21 +25,4 @@ auto queryosity::systematic::get_variation_names(Nodes const &...nodes)
   std::set<std::string> variation_names;
   (variation_names.merge(nodes.get_variation_names()), ...);
   return variation_names;
-}
-
-inline queryosity::systematic::mode::mode()
-    : m_is_nominal(true), m_variation_name("") {}
-
-inline void
-queryosity::systematic::mode::set_variation_name(const std::string &var_name) {
-  m_is_nominal = false;
-  ;
-  m_variation_name = var_name;
-}
-
-inline bool queryosity::systematic::mode::is_nominal() const {
-  return m_variation_name.empty();
-}
-inline std::string queryosity::systematic::mode::variation_name() const {
-  return m_variation_name;
 }